util/matrix: cut trailing / from SSO req, unbreak iOS Element #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Element iOS will send a request to cause Synapse to redirect to the
SSO provider with a trailing slash:
/_matrix/client/r0/login/sso/redirect/?...
This causes synapse to respond with an M_UNRECOGNIZED error. Thus, for
now, explicitly match on that URL and remove the trailing slash. nginx
takes care of the query parameters. This looks exactly like issue 4785
[1]; however this should have been fixed in all recent versions of
Element iOS.
[1]: element-hq/element-ios#4785
alevy
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Element iOS will send a request to cause Synapse to redirect to the SSO provider with a trailing slash:
This causes synapse to respond with an M_UNRECOGNIZED error. Thus, for now, explicitly match on that URL and remove the trailing slash. nginx takes care of the query parameters. This looks exactly like issue 4785 1; however this should have been fixed in all recent versions of Element iOS.
Either way, this seems like a good and uncontroversial hotfix for now. With this change Element on iOS is confirmed to be working.