Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/matrix: cut trailing / from SSO req, unbreak iOS Element #26

Merged
merged 1 commit into from
Sep 23, 2022
Merged

util/matrix: cut trailing / from SSO req, unbreak iOS Element #26

merged 1 commit into from
Sep 23, 2022

Commits on Sep 23, 2022

  1. util/matrix: cut trailing / from SSO req, unbreak iOS Element 

    Element iOS will send a request to cause Synapse to redirect to the
SSO provider with a trailing slash:

    /_matrix/client/r0/login/sso/redirect/?...

This causes synapse to respond with an M_UNRECOGNIZED error. Thus, for
now, explicitly match on that URL and remove the trailing slash. nginx
takes care of the query parameters. This looks exactly like issue 4785
[1]; however this should have been fixed in all recent versions of
Element iOS.

[1]: element-hq/element-ios#4785
    @lschuermann
    lschuermann committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    8da1155 View commit details
    Browse the repository at this point in the history