-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symfony 4.0 updates #483
Symfony 4.0 updates #483
Conversation
#SymfonyConHackday2017
* Updated format of object dumping as deprecated tags using colon symfony/yaml 38d3087
…undle commands * Updated two services to public
* macroprog/4.0: Upd: Removing old SF version + PHPUnit correction Upd: PHP 5 not supported anymore by PHPUnit Upd: Travis configuration PropelBundle for Symfony 4 Upd: Configure visibility of services for SF4 Upd: Add Symfony 4 Compatibility # Conflicts: # DataCollector/PropelDataCollector.php # DataFixtures/Dumper/YamlDataDumper.php # Tests/Model/EntryTest.php # Tests/Model/SecurityIdentityTest.php # Tests/Security/Acl/MutableAclProviderTest.php # composer.json
* reverted unnecessary changes to abstract command and schemal locator * Added fixtures for schema testing.
* reverted unnecessary changes to abstract command and schemal locator * Added fixtures for schema testing.
When this PR will be merge? |
Hi @cristianoc72 can you merge this PR? |
@eugenekurasov sorry, I can't: I haven't push rights on this repo |
Will this remove Symfony 2.8-3.x support? If so, we need to merge this in a new 4.x branch. |
It looks like @cristianoc72 confirmed working in 3.4, and I have confirmed this will break in 2.8. Shall I update the readme to reflect working versions? Looks like it would make sense to create it's own branch until I can figure out backwards compatibility |
Yes, please update the readme accordingly. I changed the target branch to 4.0 |
@kingchills can you update readme? |
* Updated readme to reflect symfony version support
@kingchills thank you |
Thanks! |
* upstream/4.0: use ChildDefinition instead of DefinitionDecorator (propelorm#485) Symfony 4.0 updates (propelorm#483)
Added support for Symfony 4.0. Updated unit tests to remove deprecated functions, and match current object serialization strings for YamlDumper