Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upd: Adding Symfony 4 Compatibility #294

Closed
wants to merge 13 commits into from
Closed

Upd: Adding Symfony 4 Compatibility #294

wants to merge 13 commits into from

Conversation

ilohpro
Copy link

@ilohpro ilohpro commented Nov 18, 2017

#SymfonyConHackday2017

@ilohpro
Copy link
Author

ilohpro commented Nov 18, 2017

Unit test has to be updated to manage the new version of Propel.
That's why Travis fails

@gilles-g
Copy link
Member

@macroprog
Did you try to not change propel dependencies?
Tests are green on master branch, this is important :)

@ilohpro
Copy link
Author

ilohpro commented Dec 8, 2017

@Spike31 Yes, i start my tests by keeping the propel version that is in the master branch, but i get a lot of other errors as I have do be on PHP 7, and propel 1 is not compatible with it.
I will try to go more in details with it as soon as i can

@Bukashk0zzz
Copy link
Contributor

Any news?

@ilohpro
Copy link
Author

ilohpro commented Dec 19, 2017

Nope, still stuck with the Propel problem, can you help please ?

@Bukashk0zzz
Copy link
Contributor

If have no ideas I will try on weekend.

@eugenekurasov
Copy link
Contributor

Hi,
You change propel/propel-bundle from ~1.5 to ~3.0@dev.
propel/propel-bundle ~1.5 using https:/propelorm/Propel
propel/propel-bundle ~3.0@dev using https:/propelorm/Propel2
Classes from https:/propelorm/Propel also used in other places (For example).

@ilohpro
Copy link
Author

ilohpro commented Dec 19, 2017

I understand that, but the bigest problem i have for now is to replace PropelQuickBuilder::buildSchema.
I can't find a solution to replace it. Do you have an idea ?

@eugenekurasov
Copy link
Contributor

I will try upgrade project to Propel2 at this weekend.

@ilohpro
Copy link
Author

ilohpro commented Jan 4, 2018

Hi, Could you upgrade the project to Propel2 as expected ? Thanks

@eugenekurasov
Copy link
Contributor

Hi, I was at vacation, I will create PR at this week.

@eugenekurasov
Copy link
Contributor

Hi,
I am done PR for migrate to Propel 2. I waiting merge.

@Bukashk0zzz
Copy link
Contributor

@macroprog can you marge sf4 support with @eugenekurasov PR. Than we can set in composer your brunch and update our project to SF4

@gilles-g
Copy link
Member

@eugenekurasov PR merged 👍

@eugenekurasov
Copy link
Contributor

@macroprog can you continue your PR? Problems with propel is should be solved

@ilohpro
Copy link
Author

ilohpro commented Jan 19, 2018

I'll do the merge on next week, i can't before

@gilles-g gilles-g mentioned this pull request Jan 25, 2018
@amitlimbadia
Copy link

gr8 so when we will have sf4 LexikTranslationBundle support?

@ilohpro
Copy link
Author

ilohpro commented Jan 28, 2018

Propel bundle has been released for SF3.* but not yet for SF4 (no branch dedicated to this version).
Travis still brake down because of it on the SF4 test and the Mongo Extension.
I'm still trying to find a solution. I'll follow in the coming week.

@amitlimbadia
Copy link

Any updates regarding symfony 4 compatibility?

@eugenekurasov
Copy link
Contributor

@macroprog PR (propelorm/PropelBundle#483) - has been merge. Can you continue this PR?

@ilohpro
Copy link
Author

ilohpro commented Feb 10, 2018

As i said in my last post, the propel bundle has been released for Symfony 3.4, but not Symfony 4 (problem with Mongo exntesion => https://travis-ci.org/lexik/LexikTranslationBundle/jobs/334241571 ).
Can you manage it on the propel bundle repo to merge it here ?

@eugenekurasov
Copy link
Contributor

Propel-bundle 3.0 will not support SF4. Propel-bundle already have branch 4.0 with support SF4.
I asked to create new tag in issue (propelorm/PropelBundle#484)

@eugenekurasov
Copy link
Contributor

@macroprog
Has been created new PR with SF4 #305

@ilohpro
Copy link
Author

ilohpro commented Feb 16, 2018

Okay, thank you for this information. I close this one as the other one is in green. Thank you for your help.

@ilohpro ilohpro closed this Feb 16, 2018
@ilohpro ilohpro deleted the feature/symfony_4_compatibility branch February 16, 2018 17:07
@gilles-g
Copy link
Member

Thx @macroprog for your time and contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants