preheat: improve target temperature threshold #4033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reason for me wanting this change is related to #4032, there is few second delay before the Full Screen message is rendered because the Preheat menu doesn't wait for the hotend to reach as high a temperature closer to the target. |
Use 5°C threshold to be consistant with other parts of the firmware. Relying on 95% of the target temperature creates a dependency on the temperature: PLA: Target = 215°C, threshold = 10.75°C PETG: Target = 230°C, threshold = 11.5°C ABS: Target = 255°C, threshold = 12.75°C ASA: Target =260°C, threshold = 13.0°C PC: Target = 275°C, threshold = 13.75°C My proposal is we instead use a constant TEMP_HYSTERESIS = 5, which is consistent with M109, and behavior when restoring print from RAM and some of the MMU code (like unload function) Change in memory: Flash: +2 bytes SRAM: 0 bytes
gudnimg
force-pushed
the
improve-preheat-target
branch
from
c47896a
to
319fec4
Compare
Let's drop the float comparison since it not needed Change in memory: Flash : -16 bytes SRAM: 0 bytes
* M600 used 1°C threshold, which may increase the waiting time a bit * Wizard used 3°C Sync both to use TEMP_HYSTERESIS for consistancy No change in memory footprint
DRracer
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 5°C threshold to be consistent with other parts of the firmware.
Relying on 95% of the target temperature creates
a dependency on the temperature. I don't see any other part of the firmware do this except the Preheat menu.
My proposal is we instead use a constant
TEMP_HYSTERESIS = 5, which is consistent withM109, and behavior when restoring print from RAM
and some of the MMU code (like unload function)
Change in memory:
Flash: -14 bytes
SRAM: 0 bytes