Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preheat: improve target temperature threshold #4033

Merged
merged 3 commits into from
Mar 3, 2023
Merged

preheat: improve target temperature threshold #4033

merged 3 commits into from
Mar 3, 2023

Commits on Feb 19, 2023

  1. preheat: improve target temperature threshold 

    Use 5°C threshold to be consistant with other parts
of the firmware.

Relying on 95% of the target temperature creates
a dependency on the temperature:

PLA: Target = 215°C, threshold = 10.75°C
PETG: Target = 230°C, threshold = 11.5°C
ABS: Target = 255°C, threshold  = 12.75°C
ASA: Target =260°C, threshold = 13.0°C
PC: Target = 275°C, threshold  = 13.75°C

My proposal is we instead use a constant
TEMP_HYSTERESIS = 5, which is consistent with
M109, and behavior when restoring print from RAM
and some of the MMU code (like unload function)

Change in memory:
Flash: +2 bytes
SRAM: 0 bytes
    @gudnimg
    gudnimg committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    319fec4 View commit details
    Browse the repository at this point in the history

  2. optimisation: preheat menu always uses integers for target temperature 

    Let's drop the float comparison since it not needed

Change in memory:
Flash : -16 bytes
SRAM: 0 bytes
    @gudnimg
    gudnimg committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    6ad126e View commit details
    Browse the repository at this point in the history

  3. preheat: sync temperature threshold in M600 and Wizard 

    * M600 used 1°C threshold, which may increase the waiting time a bit
* Wizard used 3°C

Sync both to use TEMP_HYSTERESIS for consistancy

No change in memory footprint
    @gudnimg
    gudnimg committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    496b52b View commit details
    Browse the repository at this point in the history