Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use mocha_test on non-root packages #37

Closed
driveraid opened this issue Oct 11, 2017 · 4 comments
Closed

Can't use mocha_test on non-root packages #37

driveraid opened this issue Oct 11, 2017 · 4 comments

Comments

@driveraid
Copy link

driveraid commented Oct 11, 2017

Hi @pcj, I think I found an issue with mocha_test. It appears it doesn't work for packages deeper than the workspace root.

To reproduce, simply:

$ cd tests/mocha
$ mkdir W
$ mv BUILD test.js W
$ bazel test //...

It appears the mocha launcher doesn't take the leading path into account. Please see the attachment for a solution which I verified is working both for the base package and deeper ones.

0001-Make-sure-mocha_test-can-be-used-on-other-packages-t.patch.txt

@xujihui1985
Copy link
Contributor

@driveraid this issue should has been fixed #39

@cwoodcock
Copy link

Just ran into this using head @ f990afc. Seems #41 accidentally added a regression. Backing the truck up to dc9f8ba worked around it for me. cc @pcj

@pcj
Copy link
Contributor

pcj commented Oct 25, 2017

Shucks, sorry about that. #41 was a big change. I'll take a look at this tonight.

@pcj
Copy link
Contributor

pcj commented Oct 26, 2017

Should be fixed by #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants