Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inner package test #39

Merged
merged 2 commits into from
Oct 16, 2017
Merged

fix: inner package test #39

merged 2 commits into from
Oct 16, 2017

Conversation

xujihui1985
Copy link
Contributor

fix mocha test when package is in the nest folder

@pcj
Copy link
Contributor

pcj commented Oct 13, 2017 •
edited
Loading

Hi @xujihui1985 looks good, but would it be possible to include a working sample in tests/mocha_inner (or whatever you want to call it). You could probably just copy over most of tests/mocha.

@pcj
Copy link
Contributor

pcj commented Oct 13, 2017

Actually, just adding a nested BUILD file in tests/mocha with a mocha_test rule would be less clutter.

@xujihui1985
Copy link
Contributor Author

sure, I will add a test

@xujihui1985
Copy link
Contributor Author

I have added new test under mocha test

@pcj pcj merged commit dc9f8ba into pubref:master Oct 16, 2017
@xujihui1985 xujihui1985 mentioned this pull request Oct 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xujihui1985 @pcj