Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add PdfReader.pdf_header #1013

Merged
merged 4 commits into from
Jun 26, 2022
Merged

ENH: Add PdfReader.pdf_header #1013

merged 4 commits into from
Jun 26, 2022

Conversation

MartinThoma
Copy link
Member

No description provided.

@MartinThoma
Copy link
Member Author

I'm pretty uncertain if adding this is really a good idea. I understand it's interesting, but I think people misunderstand what it means.

Also: Which format would you expect?

  1. "%PDF-1.4"
  2. "PDF-1.4"
  3. "1.4"
  4. (1, 4) -- the version-style

@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #1013 (de282c2) into main (a8c4dd9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1013      +/-   ##
==========================================
+ Coverage   89.34%   89.36%   +0.01%     
==========================================
  Files          24       24              
  Lines        4420     4427       +7     
  Branches      917      917              
==========================================
+ Hits         3949     3956       +7     
  Misses        321      321              
  Partials      150      150              
Impacted Files Coverage Δ
PyPDF2/_reader.py 91.70% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8c4dd9...de282c2. Read the comment docs.

@MartinThoma
Copy link
Member Author

Fitz (pymupdf) calls it "format" and has format (2). It's part of the Metadata there

@MartinThoma MartinThoma changed the title ENH: Add reader.pdf_version ENH: Add PdfReader.pdf_header Jun 26, 2022
@MartinThoma MartinThoma merged commit 3c750c1 into main Jun 26, 2022
@MartinThoma MartinThoma deleted the pdf-version branch June 26, 2022 06:38
MartinThoma added a commit that referenced this pull request Jun 26, 2022
New Features (ENH):
-  Support R6 decrypting (#1015)
-  Add PdfReader.pdf_header (#1013)

Performance Improvements (PI):
-  Remove ord_ calls (#1014)

Bug Fixes (BUG):
-  Fix missing page for bookmark (#1016)

Robustness (ROB):
-  Deal with invalid Destinations (#1028)

Documentation (DOC):
-  get_form_text_fields does not extract dropdown data (#1029)
-  Adjust PdfWriter.add_uri docstring
-  Mention crypto extra_requires for installation (#1017)

Developer Experience (DEV):
-  Use /n line endings everywhere (#1027)
-  Adjust string formatting to be able to use mutmut (#1020)
-  Update Bug report template

Full Changelog: 2.3.1...2.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant