ROB: Deal with invalid Destinations #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: An
AttributeError: 'NoneType' object has no attribute 'get_object'
was raised when trying to write a page that was merged.
Fix: Guard IndirectObject.get_object access
Closes #997
Codecov Report
@@ Coverage Diff @@
## main #1028 +/- ##
==========================================
+ Coverage 89.36% 89.50% +0.14%
==========================================
Files 24 24
Lines 4427 4432 +5
Branches 917 919 +2
==========================================
+ Hits 3956 3967 +11
+ Misses 321 318 -3
+ Partials 150 147 -3
Continue to review full report at Codecov.
|
MartinThoma
added a commit
that referenced
this pull request
Jun 26, 2022
New Features (ENH): - Support R6 decrypting (#1015) - Add PdfReader.pdf_header (#1013) Performance Improvements (PI): - Remove ord_ calls (#1014) Bug Fixes (BUG): - Fix missing page for bookmark (#1016) Robustness (ROB): - Deal with invalid Destinations (#1028) Documentation (DOC): - get_form_text_fields does not extract dropdown data (#1029) - Adjust PdfWriter.add_uri docstring - Mention crypto extra_requires for installation (#1017) Developer Experience (DEV): - Use /n line endings everywhere (#1027) - Adjust string formatting to be able to use mutmut (#1020) - Update Bug report template Full Changelog: 2.3.1...2.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: An
AttributeError: 'NoneType' object has no attribute 'get_object'
was raised when trying to write a page that was merged.
Fix: Guard IndirectObject.get_object access
Closes #997