Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-vv is not passed to build env install subprocesses #12577

Closed
1 task done
markmc opened this issue Mar 14, 2024 · 0 comments · Fixed by #12578
Closed
1 task done

-vv is not passed to build env install subprocesses #12577

markmc opened this issue Mar 14, 2024 · 0 comments · Fixed by #12578
Labels
S: needs triage Issues/PRs that need to be triaged type: bug A confirmed bug or unintended behavior

Comments

@markmc
Copy link
Contributor

markmc commented Mar 14, 2024

Description

While using -vv I noticed seeing a big pause between these two output lines:

Installing backend dependencies: started Installing backend dependencies: finished with status 'done'

Clearly a lot of stuff was happening - like wheel building - but there was no output

It turns out that when -vv was introduced in #9450 this higher verbosity level was not passed onto these subprocesses

Expected behavior

No response

pip version

24.0

Python version

3.9

OS

RHEL

How to Reproduce

Compare the logging output from

rm -rf ~/.cache/pip && rm -f *.whl && pip -vv wheel --no-binary :all: hatchling

before and after the patch. I'm seeing 1k lines before and 12k lines after.

Output

No response

Code of Conduct

@markmc markmc added S: needs triage Issues/PRs that need to be triaged type: bug A confirmed bug or unintended behavior labels Mar 14, 2024
markmc added a commit to markmc/pip that referenced this issue Mar 14, 2024
Fixes pypa#12577

This looks like it was an oversight in pypa#9450 - we should pass the
correct verbosity level to build env install subprocesses.

Tested with:

```
rm -rf ~/.cache/pip && rm -f *.whl && pip wheel --no-binary :all: hatchling
```

and all three verbosity levels, before and after this change, giving
the following logs:

```
     33 patched-verbosity0.log
   2549 patched-verbosity1.log
  11938 patched-verbosity2.log
     33 unpatched-verbosity0.log
     99 unpatched-verbosity1.log
   1030 unpatched-verbosity2.log
```

i.e. currently a lot of useful logs are being dropped from these install
subprocesess even with -vvv
markmc added a commit to markmc/pip that referenced this issue Mar 15, 2024
Fixes pypa#12577

This looks like it was an oversight in pypa#9450 - we should pass the
correct verbosity level to build env install subprocesses.

Tested with:

```
rm -rf ~/.cache/pip && rm -f *.whl && pip wheel --no-binary :all: hatchling
```

and all three verbosity levels, before and after this change, giving
the following logs:

```
     33 patched-verbosity0.log
   2549 patched-verbosity1.log
  11938 patched-verbosity2.log
     33 unpatched-verbosity0.log
     99 unpatched-verbosity1.log
   1030 unpatched-verbosity2.log
```

i.e. currently a lot of useful logs are being dropped from these install
subprocesess even with -vvv
markmc added a commit to markmc/pip that referenced this issue Mar 20, 2024
Fixes pypa#12577

This looks like it was an oversight in pypa#9450 - we should pass the
correct verbosity level to build env install subprocesses.

Tested with:

```
rm -rf ~/.cache/pip && rm -f *.whl && pip wheel --no-binary :all: hatchling
```

and all three verbosity levels, before and after this change, giving
the following logs:

```
     33 patched-verbosity0.log
   2549 patched-verbosity1.log
  11938 patched-verbosity2.log
     33 unpatched-verbosity0.log
     99 unpatched-verbosity1.log
   1030 unpatched-verbosity2.log
```

i.e. currently a lot of useful logs are being dropped from these install
subprocesess even with -vvv
arenasys pushed a commit to arenasys/pip that referenced this issue Mar 26, 2024
Fixes pypa#12577

This looks like it was an oversight in pypa#9450 - we should pass the
correct verbosity level to build env install subprocesses.

Tested with:

```
rm -rf ~/.cache/pip && rm -f *.whl && pip wheel --no-binary :all: hatchling
```

and all three verbosity levels, before and after this change, giving
the following logs:

```
     33 patched-verbosity0.log
   2549 patched-verbosity1.log
  11938 patched-verbosity2.log
     33 unpatched-verbosity0.log
     99 unpatched-verbosity1.log
   1030 unpatched-verbosity2.log
```

i.e. currently a lot of useful logs are being dropped from these install
subprocesess even with -vvv
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S: needs triage Issues/PRs that need to be triaged type: bug A confirmed bug or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant