Pass -vv to pip install build env subprocess #12578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmc
force-pushed
the
verbose-install-subprocess
branch
from
042d64c
to
22eabd8
Compare
Fixes pypa#12577 This looks like it was an oversight in pypa#9450 - we should pass the correct verbosity level to build env install subprocesses. Tested with: ``` rm -rf ~/.cache/pip && rm -f *.whl && pip wheel --no-binary :all: hatchling ``` and all three verbosity levels, before and after this change, giving the following logs: ``` 33 patched-verbosity0.log 2549 patched-verbosity1.log 11938 patched-verbosity2.log 33 unpatched-verbosity0.log 99 unpatched-verbosity1.log 1030 unpatched-verbosity2.log ``` i.e. currently a lot of useful logs are being dropped from these install subprocesess even with -vvv
markmc
force-pushed
the
verbose-install-subprocess
branch
from
22eabd8
to
8d81de2
Compare
pradyunsg
approved these changes
Mar 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12577
This looks like it was an oversight in #9450 - we should pass the correct verbosity level to build env install subprocesses.
Tested with:
and all three verbosity levels, before and after this change, giving the following logs:
i.e. currently a lot of useful logs are being dropped from these install subprocesess even with -vvv