Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'pip wheel --no-deps' doesn't work with extras on the new resolver #8677

Closed
rouge8 opened this issue Aug 1, 2020 · 2 comments · Fixed by #8678
Closed

'pip wheel --no-deps' doesn't work with extras on the new resolver #8677

rouge8 opened this issue Aug 1, 2020 · 2 comments · Fixed by #8678
Labels
type: bug A confirmed bug or unintended behavior
Milestone
20.2.1

Comments

@rouge8
Copy link
Contributor

rouge8 commented Aug 1, 2020

What did you want to do?

pip wheel --use-feature=2020-resolver --no-deps splitio_client[cpphash,redis]==8.2.0 -w wheels/ should download splitio_client-8.2.0-py2.py3-none-any.whl like pip wheel --no-deps splitio_client[cpphash,redis]==8.2.0 -w wheels/ does.

On its own this is an artificial case, but I broke it out of a 150 line requirements file that was failing to find the issue. :)

Output

With --use-feature=2020-resolver

$ pip wheel --use-feature=2020-resolver --no-deps splitio_client[cpphash,redis]==8.2.0 -w wheels/

(no output)

Without --use-feature=2020-resolver

$ pip wheel --no-deps splitio_client[cpphash,redis]==8.2.0 -w wheels/
Processing /Users/andy/Library/Caches/pip/wheels/5a/9a/1e/de8c54b6448f1a2615e76d5d2e7395342f9d1370865d2c0566/splitio_client-8.2.0-py2.py3-none-any.whl
  Saved ./wheels/splitio_client-8.2.0-py2.py3-none-any.whl
Skipping splitio-client, due to already being wheel.
@triage-new-issues triage-new-issues bot added the S: needs triage Issues/PRs that need to be triaged label Aug 1, 2020
@uranusjr uranusjr added C: new resolver type: bug A confirmed bug or unintended behavior labels Aug 1, 2020
@triage-new-issues triage-new-issues bot removed the S: needs triage Issues/PRs that need to be triaged label Aug 1, 2020
@uranusjr
Copy link
Member

uranusjr commented Aug 1, 2020

Can reproduce with master.

@uranusjr
Copy link
Member

uranusjr commented Aug 1, 2020 •
edited
Loading

Ah, I think I know the problem. An extra-ed package is implemented as a virtual package with a dependency on its non-extra-ed self, but --no-deps makes the new resolver skip all dependencies, including that.

Note that wheel has nothing to do with the problem. It can be reproduced with install as well. The base package won’t be installed if extras are specified in conjunction with --no-deps.

@uranusjr uranusjr mentioned this issue Aug 2, 2020
Merged
@uranusjr uranusjr added this to the 20.2.1 milestone Aug 3, 2020
bors bot referenced this issue in duckinator/emanate Aug 5, 2020
@bors @pyup-bot
Merge #158
115e02f 
158: Update pip to 20.2.1 r=duckinator a=pyup-bot


This PR updates [pip](https://pypi.org/project/pip) from **20.2** to **20.2.1**.



<details>
  <summary>Changelog</summary>
  
  
   ### 20.2.1
   ```
   ===================

Features
--------

- Ignore require-virtualenv in ``pip list`` (`8603 &lt;https:/pypa/pip/issues/8603&gt;`_)

Bug Fixes
---------

- Correctly find already-installed distributions with dot (``.``) in the name
  and uninstall them when needed. (`8645 &lt;https:/pypa/pip/issues/8645&gt;`_)
- Trace a better error message on installation failure due to invalid ``.data``
  files in wheels. (`8654 &lt;https:/pypa/pip/issues/8654&gt;`_)
- Fix SVN version detection for alternative SVN distributions. (`8665 &lt;https:/pypa/pip/issues/8665&gt;`_)
- New resolver: Correctly include the base package when specified with extras
  in ``--no-deps`` mode. (`8677 &lt;https:/pypa/pip/issues/8677&gt;`_)
- Use UTF-8 to handle ZIP archive entries on Python 2 according to PEP 427, so
  non-ASCII paths can be resolved as expected. (`8684 &lt;https:/pypa/pip/issues/8684&gt;`_)

Improved Documentation
----------------------

- Add details on old resolver deprecation and removal to migration documentation. (`8371 &lt;https:/pypa/pip/issues/8371&gt;`_)
- Fix feature flag name in docs. (`8660 &lt;https:/pypa/pip/issues/8660&gt;`_)
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/pip
  - Changelog: https://pyup.io/changelogs/pip/
  - Homepage: https://pip.pypa.io/
</details>



Co-authored-by: pyup-bot <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: bug A confirmed bug or unintended behavior
Projects
None yet
Milestone
20.2.1
Development

Successfully merging a pull request may close this issue.

New resolver no deps extras install self uranusjr/pip
2 participants
@rouge8 @uranusjr