New resolver no deps extras install self

[uranusjr]

Fix #8677. iter_dependencies(ignore_dependencies=True) feels weird, but I can’t think of a better argument name.

[uranusjr]

I dont understand the CI failures…

E       assert False
E        +  where False = contains_expected_lines("ERROR: broken 1.0 requires missing, which is not 
installed.\nbroken 1.0 requires conflict<1.0, but you'll have conflict 1.0 which is incompatible.\n", ['broken 
1.0 requires missing, which is not installed.', "broken 1.0 requires conflict<1.0, but you'll have conflict 1.0 
which is incompatible."])
E        +    where "ERROR: broken 1.0 requires missing, which is not installed.\nbroken 1.0 requires 
conflict<1.0, but you'll have conflict 1.0 which is incompatible.\n" = <tests.lib.TestPipResult object at 
0x7f2d6009be50>.stderr

But… the line is present? 😞

[pradyunsg]

See #8674 for why the CI is failing. :)

[pradyunsg]

How about... iter_requires(dependencies: bool = True)?

[pradyunsg]

On board with the overall approach (yay technical debt!) and made a suggestion for naming. :)

[uranusjr]

I think it should be the other way around though? The base requirement of an ExtrasCandidate is a dependency (in resolvelib semantics), but not listed in Requires-Dist. So it would be

def iter_dependencies(self, include_requires: bool) -> Iterable[Optional[Requirement]]:
    """Return dependencies of this candidate.

    :param include_requires: Dependencies from Requires-Dist are returned only if this is true.
    """

[pradyunsg]

Indeed! Let's do that.

[uranusjr]

Updated.