Prefix user_log (--log) entries with timestamp #6142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? Eases post-facto analysis of time spent in different phases of pip operation. Historical note: 767d11e#diff-b670e3b192038c9ffe810c1a12c0c51fL219 made it so that pip invocations emit zero timestamp information to the log file. Prior to that each pip invocation's start time was written out (search that commit's diff for [strftime]). Result: https://gist.github.com/fischman/f570886219de5c64a3b695300195c70a Resolves #6141
cjerdonek
suggested changes
Jan 18, 2019
|
@cjerdonek thanks for the quick & helpful review :) |
cjerdonek
suggested changes
Jan 19, 2019
…ouple the first time around).
|
@cjerdonek please take another look |
cjerdonek
added
type: enhancement
pradyunsg
changed the title
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
|
Issue #6587 was posted to add milliseconds to the display. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? Eases post-facto analysis of time spent in different phases of pip operation.
Historical note:
767d11e#diff-b670e3b192038c9ffe810c1a12c0c51fL219
made it so that pip invocations emit zero timestamp information to the log
file. Prior to that each pip invocation's start time was written out (search
that commit's diff for [strftime]).
Result: https://gist.github.com/fischman/f570886219de5c64a3b695300195c70a
Resolves #6141