Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix user_log (--log) entries with timestamp #6142

Merged
merged 10 commits into from
Jan 20, 2019
Merged

Prefix user_log (--log) entries with timestamp #6142

merged 10 commits into from
Jan 20, 2019

Commits on Jan 16, 2019

  1. Time-stamp lines emitted to user_log. 

    Why? Eases post-facto analysis of time spent in different phases of pip operation.

Historical note:
767d11e#diff-b670e3b192038c9ffe810c1a12c0c51fL219
made it so that pip invocations emit zero timestamp information to the log
file. Prior to that each pip invocation's start time was written out (search
that commit's diff for [strftime]).

Result: https://gist.github.com/fischman/f570886219de5c64a3b695300195c70a

Resolves #6141
    @fischman
    fischman committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    4e28e37 View commit details
    Browse the repository at this point in the history

  2. Unbreak logging tests

    @fischman
    fischman committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    dfe07c1 View commit details
    Browse the repository at this point in the history

  3. Pacify lint.

    @fischman
    fischman committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    5f083e3 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2019

  1. Addressed @cjerdonek review comments.

    @fischman
    fischman committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    3095574 View commit details
    Browse the repository at this point in the history

  2. Unbreak tests in non-PST timezones

    @fischman
    fischman committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    63a4a47 View commit details
    Browse the repository at this point in the history

  3. Unbreak tests on windows, hopefully

    @fischman
    fischman committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    4685dee View commit details
    Browse the repository at this point in the history

  4. Pacify lint

    @fischman
    fischman committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    4c8891c View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2019

  1. Addressed 2nd round of @cjerdonek review comments.

    @fischman
    fischman committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    4581dbd View commit details
    Browse the repository at this point in the history

  2. Addressed 2nd round of @cjerdonek review comments, take 2 (missed a c… 

    …ouple the first time around).
    @fischman
    fischman committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    6cb56ab View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2019

  1. Addressed 3rd round of @cjerdonek review comments.

    @fischman
    fischman committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    45de053 View commit details
    Browse the repository at this point in the history