More vistir dropping #5078
Merged
More vistir dropping #5078
+28
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamedTemporaryFile was introduced in Python 3.4. We only support Python 3.7+, hence this goes away.
Earlier versions of Python had Mapping in ``collections``. All versions after 3.4 moved Mapping to ``collections.abc`` Since we only support version 3.7+ we can drop this.
pathlib was introduced after Python3.5. We now only support Python3.7+, hence we don't need compat here.
This function is a nice to have alias for one line of code. Also, it uses OrderedDict, which is no longer needed. `dict`s after Python3.6 are guaranteed to be ordered (bonus: dict is faster than ordered dict). If we really want, we can also import it from zipp or python finder.
The former is simply a copy paste of `click.echo`. Since `click` has a much larger user base, it is likely to correct all bugs on all OSes faster.
|
@matteius when (and if) merging, please do not squash the commits. Doing so will lead to losing of a lot of information found in the commit messages. |
matteius
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to Python version 3.7+ allows us to remove more usage of vistir.
Eventually we can completely drop it, but I prefer doing this gradually instead of a giant PR.
Also, I am not done yet. Will add 2-3 more commits, and we'll continue chopping this vistir with b[i,y]te size steps.
Pun intended :-)