Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to fmt 10.1.1 and spdlog 1.12.0. #1957

Merged
merged 9 commits into from
Nov 30, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 3, 2023

This PR updates to fmt 10.1.1 and spdlog 1.12.

Depends on rapidsai/rmm#1374.

@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Nov 3, 2023
@bdice bdice changed the base branch from branch-23.12 to branch-24.02 November 20, 2023 22:06
@github-actions github-actions bot added the ci label Nov 20, 2023
@bdice
Copy link
Contributor Author

bdice commented Nov 22, 2023

One test appears to be flaky (link to log).

[ RUN      ] AnnCagraTest/AnnCagraTestF_I64.AnnCagra/201
[I] [20:21:24.406368] Recall = 0.991000 (991/1000), the error is 80.0% above the threshold (eps = 0.003000).
/opt/conda/conda-bld/work/cpp/test/neighbors/ann_cagra/../ann_cagra.cuh:271: Failure
Value of: eval_neighbours(indices_naive, indices_Cagra, distances_naive, distances_Cagra, ps.n_queries, ps.k, 0.003, min_recall)
  Actual: false (actual recall (0.99099999999999999) is lower than the minimum expected recall (0.995); eps = 0.0030000000000000001. )
Expected: true

[  FAILED  ] AnnCagraTest/AnnCagraTestF_I64.AnnCagra/201, where GetParam() = {n_queries=100, dataset shape=20000x32, k=10, auto, max_queries=10, itopk_size=64, search_width=1, metric=0, host, build_algo=NN_DESCENT}

@bdice bdice changed the title Build with fmt 10.1.1 and spdlog 1.12.0. Update to fmt 10.1.1 and spdlog 1.12.0. Nov 30, 2023
@bdice bdice marked this pull request as ready for review November 30, 2023 16:04
@bdice bdice requested review from a team as code owners November 30, 2023 16:04
@bdice
Copy link
Contributor Author

bdice commented Nov 30, 2023

Revert changes that use CI artifacts and the upstream rapids-cmake branch before merging.

@bdice bdice added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Nov 30, 2023
@bdice bdice removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Nov 30, 2023
@bdice
Copy link
Contributor Author

bdice commented Nov 30, 2023

/merge

@raydouglass raydouglass merged commit ff60d3a into rapidsai:branch-24.02 Nov 30, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants