Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to fmt 10.1.1 and spdlog 1.12.0. #1374

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 3, 2023

This PR updates to fmt 10.1.1 and spdlog 1.12.

Depends on rapidsai/rapids-cmake#473.

Closes #1356

@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Nov 3, 2023
@github-actions github-actions bot added the conda label Nov 3, 2023
@bdice bdice changed the base branch from branch-23.12 to branch-24.02 November 20, 2023 22:00
@bdice bdice marked this pull request as ready for review November 30, 2023 15:52
@bdice bdice requested a review from a team as a code owner November 30, 2023 15:52
fetch_rapids.cmake Outdated Show resolved Hide resolved
@bdice bdice added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Nov 30, 2023
@bdice bdice changed the title Build with fmt 10.1.1 and spdlog 1.12.0. Update to fmt 10.1.1 and spdlog 1.12.0. Nov 30, 2023
@bdice bdice self-assigned this Nov 30, 2023
@bdice bdice removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Nov 30, 2023
@bdice
Copy link
Contributor Author

bdice commented Nov 30, 2023

/merge

@rapids-bot rapids-bot bot merged commit d8579b7 into rapidsai:branch-24.02 Nov 30, 2023
47 checks passed
raydouglass pushed a commit to rapidsai/cudf that referenced this pull request Nov 30, 2023
This PR updates to fmt 10.1.1 and spdlog 1.12.

Depends on rapidsai/rmm#1374.

Authors:
   - Bradley Dice (https:/bdice)

Approvers:
   - Vyas Ramasubramani (https:/vyasr)
   - Yunsong Wang (https:/PointKernel)
   - Ray Douglass (https:/raydouglass)
   - Jake Awe (https:/AyodeAwe)
raydouglass pushed a commit to rapidsai/raft that referenced this pull request Nov 30, 2023
This PR updates to fmt 10.1.1 and spdlog 1.12.

Depends on rapidsai/rmm#1374.

Authors:
   - Bradley Dice (https:/bdice)

Approvers:
   - Jake Awe (https:/AyodeAwe)
   - Vyas Ramasubramani (https:/vyasr)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Update to spdlog 1.12 and fmt 10
2 participants