Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] rapids-cmake pinning override allow generation via CMake variable #552

Closed
robertmaynard opened this issue Mar 5, 2024 · 1 comment · Fixed by #596 or #600
Closed

[FEA] rapids-cmake pinning override allow generation via CMake variable #552

robertmaynard opened this issue Mar 5, 2024 · 1 comment · Fixed by #596 or #600
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@robertmaynard
Copy link
Contributor

Is your feature request related to a problem? Please describe.

We should think about allowing projects that want to use rapids_cpm_generate_pinned_versions to do so without having to modify the CMake logic of the project.

Describe the solution you'd like
We should support generation via a CMake variable such as RAPIDS_CMAKE_GENERATE_PINNED_VERSIONS

Describe alternatives you've considered
Thought about env variables, doesn't feel explicit enough.

Additional context
#530 (review)
@robertmaynard robertmaynard added feature request New feature or request ? - Needs Triage Need team to review and classify labels Mar 5, 2024
@robertmaynard robertmaynard mentioned this issue Apr 19, 2024
Closed
@robertmaynard robertmaynard mentioned this issue Apr 26, 2024
Merged
4 tasks
@rapids-bot rapids-bot bot closed this as completed in #596 May 3, 2024
rapids-bot bot pushed a commit that referenced this issue May 3, 2024
@robertmaynard
Allow for cpm default and override files via variables (#596)
3771f87 
Extends #595 with support for setting the default and override file used by rapids-cmake via the command line.

Fixes #552 #587

Authors:
  - Robert Maynard (https:/robertmaynard)

Approvers:
  - Vyas Ramasubramani (https:/vyasr)

URL: #596
@robertmaynard robertmaynard reopened this May 3, 2024
@robertmaynard
Copy link
Contributor Author

Was incorrectly associated to PR #596. This task still needs implementing

robertmaynard added a commit to robertmaynard/rapids-cmake that referenced this issue May 3, 2024
@robertmaynard
rapids-cmake allow GENERATE_PINNED_VERSIONS via CMake variable
67134a6 
Fixes rapidsai#552
@robertmaynard robertmaynard mentioned this issue May 3, 2024
Merged
3 tasks
robertmaynard added a commit to robertmaynard/rapids-cmake that referenced this issue May 7, 2024
@robertmaynard
rapids-cmake allow GENERATE_PINNED_VERSIONS via CMake variable
ab04826 
Fixes rapidsai#552
robertmaynard added a commit to robertmaynard/rapids-cmake that referenced this issue May 10, 2024
@robertmaynard
rapids-cmake allow GENERATE_PINNED_VERSIONS via CMake variable
ea37460 
Fixes rapidsai#552
@rapids-bot rapids-bot bot closed this as completed in #600 May 10, 2024
rapids-bot bot pushed a commit that referenced this issue May 10, 2024
@robertmaynard
rapids-cmake allow GENERATE_PINNED_VERSIONS via CMake variable (#600)
a82996c 
Fixes #552

Authors:
  - Robert Maynard (https:/robertmaynard)

Approvers:
  - Kyle Edwards (https:/KyleFromNVIDIA)

URL: #600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@robertmaynard