Expand rapids_cpm_init to support custom default version files #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
feature request
4 tasks
KyleFromNVIDIA
requested changes
Apr 26, 2024
| if(already_loaded) | ||
| return() | ||
| endif() | ||
| set_property(GLOBAL PROPERTY rapids_cpm_load_presets "ON") | ||
| set_property(GLOBAL PROPERTY rapids_cpm_load_presets_${_rapids_preset_version_file} "ON") |
There was a problem hiding this comment.
One thing to consider here is that the same file might be accessed by different relative paths, and thus will set two different properties. If this is merely a cache for optimization then it might not matter.
There was a problem hiding this comment.
This is a cache optimization. Since we check if a package has been loaded before adding it, loadin the same file multiple times would become a slow no-op.
Co-authored-by: Kyle Edwards <[email protected]>
KyleFromNVIDIA
approved these changes
May 1, 2024
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
May 3, 2024
Extends #595 with support for setting the default and override file used by rapids-cmake via the command line. Fixes #552 #587 Authors: - Robert Maynard (https:/robertmaynard) Approvers: - Vyas Ramasubramani (https:/vyasr) URL: #596
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First step to implelementing #587.
Exposes a new
CUSTOM_DEFAULT_VERSION_FILEoption torapids_cpm_initthat allows projects to specify a new default versions.json to be used instead of the one packaged with rapids-cmakeChecklist
cmake-format.jsonis up to date with these changes.