[FEA] Use the GitHub .zip URI instead of GIT_REPOSITORY and GIT_BRANCH
#257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
added
3 - Ready for Review
|
With the update to the latest version of CPM it handles setting Given the switch to a zip in RAPIDS.cmake we should also enable |
robertmaynard
requested changes
Aug 30, 2022
bdice
reviewed
Aug 30, 2022
Co-authored-by: Robert Maynard <[email protected]> Co-authored-by: Bradley Dice <[email protected]>
robertmaynard
approved these changes
Aug 30, 2022
|
rerun tests |
bdice
approved these changes
Aug 30, 2022
…po,sha,tag,branch}
bdice
approved these changes
Sep 1, 2022
Co-authored-by: Bradley Dice <[email protected]>
robertmaynard
approved these changes
Sep 1, 2022
|
@robertmaynard @trxcllnt is this PR waiting on anything or can it be merged? |
|
@gpucibot merge |
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/rapids-cmake
that referenced
this pull request
Aug 20, 2024
rapidsai#257 updated the readme, but forgot to update `basics.rst`. Copy the text from the readme.
7 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
#257 updated the readme, but forgot to update `basics.rst`. Copy the text from the readme. Authors: - Kyle Edwards (https:/KyleFromNVIDIA) Approvers: - Bradley Dice (https:/bdice) - James Lamb (https:/jameslamb) URL: #681
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the GitHub
.zipURI instead ofGIT_REPOSITORYandGIT_BRANCHsorapids-cmakecan be loaded on machines that don't have git installed. It might also be good to setCMP0135inRAPIDS.cmake.