Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for overriding rapids-cmake #681

Merged

Conversation

KyleFromNVIDIA
Copy link
Contributor

Description

#257 updated the readme, but forgot to update basics.rst. Copy the text from the readme.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

rapidsai#257 updated the readme,
but forgot to update `basics.rst`. Copy the text from the readme.
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner August 20, 2024 20:43
@KyleFromNVIDIA KyleFromNVIDIA added doc Documentation non-breaking Introduces a non-breaking change labels Aug 20, 2024
docs/basics.rst Outdated Show resolved Hide resolved
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@robertmaynard
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 9a57b13 into rapidsai:branch-24.10 Aug 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants