[dashboard] restrict aiohttp version #46902
Conversation
python/requirements.txt
Outdated
| @@ -48,7 +48,7 @@ scikit-image==0.21.0 | |||
| prometheus_client>=0.7.1 | |||
| pandas | |||
| tensorboardX | |||
| aiohttp>=3.7,!=3.9.0 | |||
| aiohttp>=3.7,<3.9 | |||
There was a problem hiding this comment.
w00t, we need to make it possible to go above 3.9 so that ray can be installed with python 3.12; this change has been here when the tests pass previously too i think
There was a problem hiding this comment.
based on the slack thread, perhaps change this to <3.10.0, and then you don't need other changes to the requirements file
There was a problem hiding this comment.
Let me make the change and test it.
Signed-off-by: Rui Qiao <[email protected]>
ruisearch42
force-pushed
the
deflake_aiohttp
branch
from
f9dc554
to
82739eb
Compare
| @@ -48,7 +48,7 @@ scikit-image==0.21.0 | |||
| prometheus_client>=0.7.1 | |||
| pandas | |||
| tensorboardX | |||
| aiohttp>=3.7,!=3.9.0 | |||
| aiohttp>=3.7,<3.10.0 | |||
There was a problem hiding this comment.
you might still want to keep the !=3.9.0 at the same time?
There was a problem hiding this comment.
I am assuming the !=3.9.0 was there for some reason..
There was a problem hiding this comment.
you also need to update the setup.py
There was a problem hiding this comment.
it used to be <3.9.0 and I changed it to !=3.9.0; nothing specific about 3.9.0, <3.10.0 is properly fine (this file is only used to build the ray docker image, not user-impacting)
Signed-off-by: Rui Qiao <[email protected]>
|
@alanwguo should we create an issue and assign to you for all the |
I can take the dashboard related ones. Looks like there's a bunch of usage in ray serve as well. @akshay-anyscale's team should own that. |
The serve ones are trivial and only used in tests, I'll put up a PR shortly |
…ext (#46917) <!-- Thank you for your contribution! Please review https:/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? See: #46902 ## Related issue number <!-- For example: "Closes #1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( Signed-off-by: Edward Oakes <[email protected]>
|
still failing, this is a cache-poisoning issue, @ruisearch42 can you remove this line here https:/ray-project/ray/blob/master/ci/docker/base.test.Dockerfile#L56 in this PR just to invalidate the cache, thankks |
Signed-off-by: Rui Qiao <[email protected]>
ruisearch42
force-pushed
the
deflake_aiohttp
branch
from
77d2fb6
to
b5b5be6
Compare
Why are these changes needed?
aiohttp's new 3.10.0 stops supporting creating
ClientSessionin non async context any more.aio-libs/aiohttp#8555 (comment)
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.