Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] restrict aiohttp version #46902

Merged
merged 3 commits into from
Aug 1, 2024
Merged

[dashboard] restrict aiohttp version #46902

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82739eb
deflake
ruisearch42 Jul 31, 2024
afd33e6
up
ruisearch42 Jul 31, 2024
b5b5be6
up
ruisearch42 Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ scikit-image==0.21.0
prometheus_client>=0.7.1
pandas
tensorboardX
aiohttp>=3.7,!=3.9.0
aiohttp>=3.7,<3.10.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might still want to keep the !=3.9.0 at the same time?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming the !=3.9.0 was there for some reason..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need to update the setup.py

Copy link
Collaborator

@can-anyscale can-anyscale Jul 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it used to be <3.9.0 and I changed it to !=3.9.0; nothing specific about 3.9.0, <3.10.0 is properly fine (this file is only used to build the ray docker image, not user-impacting)

starlette
typer
fsspec
Expand Down