Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set up pre-release workflow #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonkoops
Copy link
Contributor

What kind of change does this PR introduce?

  • Bug Fix
  • Feature
  • Refactoring
  • Style
  • Build
  • Chore
  • Documentation
  • CI

Did you add tests for your changes?

  • Yes, my code is well tested
  • Not relevant

If relevant, did you update the documentation?

  • Yes, I've updated the documentation
  • Not relevant

Summary
Sets up the release workflow with the latest conventions from semantic release. This includes a beta branch for pre-releases and NPM provenance.

Does this PR introduce a breaking change?
Nope.

Other information
None.

@jonkoops
Copy link
Contributor Author

Looks like the failures here are some kind of bug likely due to older workflows, I've created #95 to upgrade everything and that seems to fix it.

@rolandjitsu
Copy link
Collaborator

rolandjitsu commented Oct 13, 2024

Looks like the failures here are some kind of bug likely due to older workflows, I've created #95 to upgrade everything and that seems to fix it.

Those are probably showing up because of some settings in the PR merge settings/rules. I'll have a look.

Actually, the test failure on node 14 seems legit.

package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
@jonkoops
Copy link
Contributor Author

Actually, the test failure on node 14 seems legit.

Looking at the logs I see it is using NPM 10, even though NPM 9 is installed explicitly. I am not quite sure why this is happening to be honest.

@rolandjitsu
Copy link
Collaborator

Actually, the test failure on node 14 seems legit.

Looking at the logs I see it is using NPM 10, even though NPM 9 is installed explicitly. I am not quite sure why this is happening to be honest.

It would be good to get this passing as well if possible.

Comment on lines +24 to +25
with:
fetch-depth: 0 # fetch all history
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? Defaults should work.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be there as semantic release needs to know the commit history, it it is omitted only the last commit is present. You can also see it in the example code.

Comment on lines +9 to +10
permissions:
contents: read # for checkout
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a global setting for any operation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, this sets up the minimum permissions for the entire workflow. Individual jobs can then specify the permissions they need individually.

@jonkoops
Copy link
Contributor Author

Actually, the test failure on node 14 seems legit.

I'll check it out when I have some more time. Let's get #95 merged first just to make sure the actions or environment don't have anything to do with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants