chore: clean up test workflow #95
Conversation
jonkoops
force-pushed
the
test-workflow-cleanup
branch
from
4a92843
to
be50371
Compare
Pull Request Test Coverage Report for Build 11391922952Details
💛 - Coveralls |
| @@ -5,41 +5,47 @@ on: | |||
| - master | |||
| - "[0-9]+.[0-9]+.x" | |||
| pull_request: | |||
| types: [opened, synchronize] | |||
There was a problem hiding this comment.
Why remove this? We don't want to run tests for every single branch unless it's beta/master/maintenance and for PRs.
There was a problem hiding this comment.
The default types are opened, synchronize and reopened, so falling back to the default here will result in pretty much exactly the desired behaviour.
There was a problem hiding this comment.
I just find it odd to leave the pull_request key without any props 😆 In the spirit of being explicit as you were with the other changes, I'd prefer to keep this one as well.
There was a problem hiding this comment.
It's pretty common to do this in GitHub Actions, for example many of the examples in the documentation only specify a trigger without a type. But if you feel strongly about it I will change it.
jonkoops
force-pushed
the
test-workflow-cleanup
branch
from
be50371
to
3cffac7
Compare
|
@rolandjitsu would you like me to make any further changes, or can we get this merged? |
| @@ -5,41 +5,47 @@ on: | |||
| - master | |||
| - "[0-9]+.[0-9]+.x" | |||
| pull_request: | |||
| types: [opened, synchronize] | |||
There was a problem hiding this comment.
I just find it odd to leave the pull_request key without any props 😆 In the spirit of being explicit as you were with the other changes, I'd prefer to keep this one as well.
Signed-off-by: Jon Koops <[email protected]>
jonkoops
force-pushed
the
test-workflow-cleanup
branch
from
3cffac7
to
5ce21f7
Compare
|
@rolandjitsu added the suggested changes, let me know what you think. |
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Cleans up the test workflow to use all the latest versions of various actions.
Does this PR introduce a breaking change?
No.
Other information
None.