Support contextDir for Buildpack strategies #212
Conversation
|
/assign @zhangtbj |
|
/assign @sbose78 |
|
/ok-to-test |
openshift-ci-robot
added
the
ok-to-test
|
Thinking out aloud, could some samples be moved to the |
|
@sbose78 like all samples into |
|
@sbose78, fyi I think I addressed your
which I think is correct to do. |
samples/buildstrategy/buildpacks-v3/buildstrategy_buildpacks-v3_cr.yaml
Outdated
Show resolved
Hide resolved
samples/buildstrategy/buildpacks-v3/buildstrategy_buildpacks-v3_namespaced_cr.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@qu1queee Please also update the documentation: https:/redhat-developer/build/blame/28b684cd8f24e962993486a930024387d3502bf5/docs/build.md#L62
|
@SaschaSchwarze0 yes, thanks! |
Add new test samples with Buildpacks that build the following runtimes: - ruby - php - nodejs All of the above use the same source repository.
For Builds that use a contextDir and with different runtimes. This currently uses heroku.
|
@qu1queee Samples directory layout looks good! |
Move buildpacks runtimes samples under the test dir Add new runtimes: golang and java for paketo Update docs
|
@xiujuan95 can u pls take a look on this PR? |
|
/lgtm |
|
/lgtm |
|
@xiujuan95: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
We already verified and confirmed the ruby buildpacks work fine and other functions work. Merged |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhangtbj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Based on #195
This adds support for
contextDirso that Builds usingBuildpacks v3strategies can specify a directory path under the source code. This is very helpful, specially because for buildpacks we can reuse the different sample applications that the CF community have in assetsAlso, adding samples and e2e test for different runtimes(php,nodejs,ruby) using the above sample apps.
This PR also inline with the #190, it should simplify that work.