[v23.2.x] cloud_storage: Prevent misaligned segment reuploads #12973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests are checking compacted reupload that starts in a gap. The situation is impossible in redpanda since we can't have gaps in the manifest. The tests are failing when strict checks on segment metadata are enabled. Only alinged segment reuploads are allowed by these checks so the reupload that starts in the gap can't really be registred by the archival STM. (cherry picked from commit aa2348f)
Validate compacted segments inside the 'safe_segment_meta_to_add' method. Do not allow segment reuploads which are not aligned with existing segments in the manifest. (cherry picked from commit b72061c)
andijcr
approved these changes
Aug 23, 2023
|
Failure seems to be #12402 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #12966
Fixes #12974 12974