Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.2.x] cloud_storage: Prevent misaligned segment reuploads #12973

Merged
merged 2 commits into from
Aug 24, 2023
Merged

[v23.2.x] cloud_storage: Prevent misaligned segment reuploads #12973

merged 2 commits into from
Aug 24, 2023

Commits on Aug 23, 2023

  1. archival: Remove tests that check gap reupload 

    The tests are checking compacted reupload that starts in a gap. The
situation is impossible in redpanda since we can't have gaps in the
manifest. The tests are failing when strict checks on segment metadata
are enabled. Only alinged segment reuploads are allowed by these checks
so the reupload that starts in the gap can't really be registred by
the archival STM.

(cherry picked from commit aa2348f)
    @Lazin @vbotbuildovich
    Lazin authored and vbotbuildovich committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    6afeffa View commit details
    Browse the repository at this point in the history

  2. cloud_storage: Validate compacted segment reuploads 

    Validate compacted segments inside the 'safe_segment_meta_to_add'
method. Do not allow segment reuploads which are not aligned with
existing segments in the manifest.

(cherry picked from commit b72061c)
    @Lazin @vbotbuildovich
    Lazin authored and vbotbuildovich committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    12e170f View commit details
    Browse the repository at this point in the history