Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move module-info.class to root of jar? #674

Closed
remkop opened this issue Apr 27, 2019 · 3 comments
Closed

Move module-info.class to root of jar? #674

remkop opened this issue Apr 27, 2019 · 3 comments
Labels
theme: module An issue or change related to JPMS modules type: enhancement ✨
Milestone

Comments

@remkop
Copy link
Owner

remkop commented Apr 27, 2019

This is a follow-up item for #495.
Having the module-info.class in /META-INF/releases/9/ apparently also has drawbacks.

Charles Nutter reported he had issues after putting the module-info.class in /META-INF/releases/9/ :
https://twitter.com/headius/status/1037931427000725504

So it may be safer to put it in the root of the jar after all. Since we publish two artifacts, old tools that cannot handle Java 9 bytecodes can always use the non-modular picocli.jar.

@Warkdev
Copy link

Warkdev commented Apr 27, 2019

Hi, just revert this commit: 095ea30

Warkdev

@remkop
Copy link
Owner Author

remkop commented Apr 27, 2019

Cool, thanks!
I’ll first try to reproduce the problem to see if this is really necessary.

@remkop
Copy link
Owner Author

remkop commented May 9, 2019

(Note to self) The beryx/badass-jar-plugin has a setting to prevent the creation of a multi-release jar:

jar {
    ...
    multiRelease = false
    ...
}

@remkop remkop modified the milestones: 4.0, 4.0-alpha-3 May 9, 2019
@remkop remkop closed this as completed in 8896d2c May 9, 2019
remkop added a commit that referenced this issue May 11, 2019
@remkop remkop mentioned this issue May 31, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: module An issue or change related to JPMS modules type: enhancement ✨
Projects
None yet
Development

No branches or pull requests

2 participants