-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move module-info.class to root of jar? #674
Labels
Milestone
Comments
Hi, just revert this commit: 095ea30 Warkdev |
Cool, thanks! |
(Note to self) The beryx/badass-jar-plugin has a setting to prevent the creation of a multi-release jar:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a follow-up item for #495.
Having the
module-info.class
in/META-INF/releases/9/
apparently also has drawbacks.Charles Nutter reported he had issues after putting the
module-info.class
in/META-INF/releases/9/
:https://twitter.com/headius/status/1037931427000725504
So it may be safer to put it in the root of the jar after all. Since we publish two artifacts, old tools that cannot handle Java 9 bytecodes can always use the non-modular
picocli.jar
.The text was updated successfully, but these errors were encountered: