-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
picocli modularization #711
Labels
theme: module
An issue or change related to JPMS modules
Milestone
Comments
remkop
added a commit
that referenced
this issue
May 31, 2019
remkop
added a commit
that referenced
this issue
May 31, 2019
remkop
added a commit
that referenced
this issue
May 31, 2019
remkop
added a commit
that referenced
this issue
May 31, 2019
remkop
added a commit
that referenced
this issue
Jun 1, 2019
remkop
added a commit
that referenced
this issue
Jun 2, 2019
remkop
added a commit
that referenced
this issue
Jun 2, 2019
remkop
added a commit
that referenced
this issue
Jun 3, 2019
…cocli:picocli-groovy:4.x') from now on
remkop
added a commit
that referenced
this issue
Jun 3, 2019
remkop
added a commit
that referenced
this issue
Jun 5, 2019
… rootProject to compile src/main/java9/module-info.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following up on #479, #495 and #674: I'm not entirely happy with the current solution for picocli modularization. Ideally, it should look more like this:
picocli
(the main jar) a full JPMS module (nameinfo.picocli
), withmodule-info.class
inMETA-INF/versions/9
, and no Groovy classespicocli-groovy
subproject, make it an automatic module with nameinfo.picocli.groovy
, and move thepicocli.groovy
package in herepicocli-legacy
orpicocli-all
artifact that is not a JPMS module and has both the java and the groovy stuff) - closing for now, awaiting community feedbackRelated tasks:
picocli-examples
to havepicocli-groovy
as a dependency@Grab
should now usepicocli-groovy
instead ofpicocli
picocli
core with a module-aware version of java - split off to Generate javadoc for picocli.jar with java 9+ #714picocli-groovy
subprojectpicocli-groovy
artifactpicocli
JPMS module (link to this article?)JCommander users may be interested in this.
The text was updated successfully, but these errors were encountered: