Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picocli modularization #711

Closed
9 tasks done
remkop opened this issue May 31, 2019 · 0 comments
Closed
9 tasks done

picocli modularization #711

remkop opened this issue May 31, 2019 · 0 comments
Labels
theme: module An issue or change related to JPMS modules
Milestone

Comments

@remkop
Copy link
Owner

remkop commented May 31, 2019

Following up on #479, #495 and #674: I'm not entirely happy with the current solution for picocli modularization. Ideally, it should look more like this:

  1. Make picocli (the main jar) a full JPMS module (name info.picocli), with module-info.class in META-INF/versions/9, and no Groovy classes
  2. Add picocli-groovy subproject, make it an automatic module with name info.picocli.groovy, and move the picocli.groovy package in here
  3. Potentially (if requested by the community) add a picocli-legacy or picocli-all artifact that is not a JPMS module and has both the java and the groovy stuff) - closing for now, awaiting community feedback

Related tasks:

  • update picocli-examples to have picocli-groovy as a dependency
  • update docs: @Grab should now use picocli-groovy instead of picocli
  • generate javadoc for picocli core with a module-aware version of java - split off to Generate javadoc for picocli.jar with java 9+ #714
  • README for picocli-groovy subproject
  • update user manual for picocli-groovy artifact
  • update user manual for picocli JPMS module (link to this article?)

JCommander users may be interested in this.

@remkop remkop added the theme: module An issue or change related to JPMS modules label May 31, 2019
@remkop remkop added this to the 4.0-beta-1 milestone May 31, 2019
remkop added a commit that referenced this issue May 31, 2019
remkop added a commit that referenced this issue May 31, 2019
remkop added a commit that referenced this issue May 31, 2019
remkop added a commit that referenced this issue Jun 2, 2019
remkop added a commit that referenced this issue Jun 3, 2019
remkop added a commit that referenced this issue Jun 3, 2019
@remkop remkop closed this as completed Jun 3, 2019
remkop added a commit that referenced this issue Jun 5, 2019
… rootProject to compile src/main/java9/module-info.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: module An issue or change related to JPMS modules
Projects
None yet
Development

No branches or pull requests

1 participant