Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Sink to Snowflake #2115

Merged
merged 16 commits into from
May 10, 2024
Merged

Conversation

WanYixian
Copy link
Contributor

@WanYixian WanYixian commented Apr 29, 2024

Info

For reviewers

  • Preview

    • [ Paste the preview link to the updated page(s) here. Edit this item after the preview site is ready. To find the updated pages, scroll down to locate and open the Amplify preview link and select the dev version of the documentation. ]
  • Key points

    • [ Parts that may need revision or extra consideration. ]

Before merging

  • I have checked the doc site preview, and the updated parts look good.

  • I have acquired the approval from the owner (and optionally the reviewers) of the code PR and at least one tech writer (CharlieSYH, emile-00, & hengm3467).

@WanYixian WanYixian linked an issue Apr 29, 2024 that may be closed by this pull request
@WanYixian WanYixian marked this pull request as draft April 29, 2024 10:09
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2115.d2fbku9n2b6wde.amplifyapp.com

@WanYixian WanYixian marked this pull request as ready for review April 30, 2024 10:03
Copy link
Contributor

@ShanlanLi ShanlanLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave some comments. Others LGTM, thanks.

docs/guides/sink-to-snowflake.md Outdated Show resolved Hide resolved
docs/guides/sink-to-snowflake.md Show resolved Hide resolved
docs/guides/sink-to-snowflake.md Outdated Show resolved Hide resolved
docs/guides/sink-to-snowflake.md Outdated Show resolved Hide resolved
docs/guides/sink-to-snowflake.md Outdated Show resolved Hide resolved
docs/guides/sink-to-snowflake.md Show resolved Hide resolved
docs/guides/sink-to-snowflake.md Show resolved Hide resolved
docs/guides/sink-to-snowflake.md Show resolved Hide resolved
docs/guides/sink-to-snowflake.md Outdated Show resolved Hide resolved
| snowflake.account_identifier | The unique `account_identifier` provided by Snowflake. Please use the form `<orgname>-<account_name>`. See [Account identifiers](https://docs.snowflake.com/en/user-guide/admin-account-identifier) for more details.|
| snowflake.user | The user that owns the table to be sinked. The user should have been granted corresponding *role*. See [Grant role](https://docs.snowflake.com/en/sql-reference/sql/grant-role) for more details. |
| snowflake.rsa_public_key_fp | The public key fingerprint used when generating custom `jwt_token`. See [Authenticating to the server](https://docs.snowflake.com/en/developer-guide/sql-api/authenticating) for more details. |
| snowflake.private_key | The rsa pem key **without** encryption. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think giving the pem content directly is somehow counterintuitive. We may give a more concrete example of this. cc @xxhZs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is paired with the rsa_public_key_fp above, is it possible to post the same connection from above again
https://docs.snowflake.com/en/developer-guide/sql-api/authenticating

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is paired with the rsa_public_key_fp above, is it possible to post the same connection from above again
https://docs.snowflake.com/en/developer-guide/sql-api/authenticating

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to merge this PR now, so create this issue to track, as it takes a while and it's nice-to-have.


## Required permission

To successfully sink data into Snowflake, the user account must have the appropriate permissions. These permissions include:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be helpful to clarify if it's the RisingWave user account or the Snowflake user account that needs the permissions.

snowflake.s3_path = 'EXAMPLE_S3_PATH',
-- depends on your mv setup, note that snowflake sink *only* supports
-- `append-only` mode at present.
force_append_only = 'true'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

force_append_only should be included in the Parameters section.

snowflake.aws_region = 'EXAMPLE_REGION',
snowflake.s3_path = 'EXAMPLE_S3_PATH',
-- depends on your mv setup, note that snowflake sink *only* supports
-- `append-only` mode at present.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should note these limitations elsewhere if necessary.

| Parameter | Description |
|-------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------|
| snowflake.database | The Snowflake database used for sinking. |
| snowflake.schema | The corresponding schema where sink table exists. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be important to emphasize here that only the name of the schema is needed

@WanYixian WanYixian merged commit a5a81a9 into main May 10, 2024
3 checks passed
@WanYixian WanYixian deleted the 2057-document-featsink-implement-snowflake-sink branch May 10, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants