feat(snowflake-sink): add example use case & detailed spec; fix a subtle problem regarding file_suffix
#16241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenym1
approved these changes
Apr 11, 2024
| @@ -288,13 +288,14 @@ impl SnowflakeSinkWriter { | |||
| if self.payload.is_empty() { | |||
| return Ok(()); | |||
| } | |||
| let file_suffix = self.file_suffix(); | |||
| // todo: change this to streaming upload | |||
There was a problem hiding this comment.
We should have replaced the current implementation with streaming upload in the original PR. Any plan to do it? It shouldn't involve too much work.
There was a problem hiding this comment.
I'll come with the refactor tomorrow.
wcy-fdu
pushed a commit
that referenced
this pull request
Apr 15, 2024
…tle problem regarding `file_suffix` (#16241)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
as titled.
related: #15429, #15429 (comment).
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
official documentation for snowflake sink could refer to this pr.