Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the test and sink_decouple = false cases #18276

Closed
chenzl25 opened this issue Aug 27, 2024 · 0 comments
Closed

Handle the test and sink_decouple = false cases #18276

chenzl25 opened this issue Aug 27, 2024 · 0 comments
Assignees
@xxhZs
Milestone
release-2.1

Comments

@chenzl25
Copy link
Contributor 

          Why not change the sink test as well? This PR changes the default behavior of all sinks to decouple. We should make the test compatible with this change. BTW, what if we `set sink_decouple = false`? It would cause an error 

config `commit_checkpoint_interval` larger than 1, which means that sink decouple must be enabled, but session config sink_decouple is disabled.

Originally posted by @chenzl25 in #18182 (comment)
@github-actions github-actions bot added this to the release-2.1 milestone Aug 27, 2024
@xxhZs xxhZs closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xxhZs xxhZs

Labels
None yet
Projects
None yet
Milestone
release-2.1
Development

No branches or pull requests
2 participants
@chenzl25 @xxhZs