feat(sink): set default_sink_decouple = true for all sink

[xxhZs]

su

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#17095

Checklist

• I have written necessary rustdoc comments
• I have added necessary unit tests and integration tests
• I have added test labels as necessary. See details.
• I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
• My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
• All checks passed in ./risedev check (or alias, ./risedev c)
• My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

• My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

• My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

after this pr,
all sink sink_decouple default is true
And starrocks clickhouse iceberg deltalake 's default commit_checkpoint_interval is 1

[hzxa21]

LGTM.

For sinks that can configure commit_checkpoint_interval, will increasing commit_checkpoint_interval from 1 to 10 cause more memory pressure on the compute node? In other words, is the buffering before commit happen in RW CN's memory or in external sink?

@wenym1 PTAL as well.

[wenym1]

Rest LGTM

[wenym1]

Is setting this field just to implicitly enable sink decouple, or it becomes required to set this field after this PR?

[xxhZs]

Because sink_decouple = false will report an error when commit_checkpoint_interval >10;
And in ci , we need sink_decouple = false to ensure that flush can flush data to sink.
So we set commit_checkpoint_interval = 1,
After this PR, if it is not set, a default value of 10 will be given

[fuyufjh]

LGTM and Thanks!

By the way, there are several open PRs listed in #17095 (comment), cc. reviewer @wenym1

[fuyufjh]

Regarding of the change to default value, don't forget to update the doc as well. :)

[chenzl25]

Why not change the sink test as well? This PR changes the default behavior of all sinks to decouple. We should make the test compatible with this change. BTW, what if we set sink_decouple = false? It would cause an error

config `commit_checkpoint_interval` larger than 1, which means that sink decouple must be enabled, but session config sink_decouple is disabled.