refactor(expr): support variadic function in #[function] macro

[wangrunji0408]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR adds variadic support to #[function] macro.

#[function("array(...) -> list")]
fn array(row: impl Row) -> ListValue {
    ListValue::new(row.iter().map(|d| d.to_owned_datum()).collect())
}

Then we migrate the following functions using the macro:

• array
• row
• concat_ws
• format

Checklist

• I have written necessary rustdoc comments
• I have added necessary unit tests and integration tests
• I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
• My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
• All checks passed in ./risedev check (or alias, ./risedev c)
• My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

• My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

• My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

format() function now support variable inputs.

[codecov]

Codecov Report

Merging #12178 (c21eaab) into main (9814af8) will decrease coverage by 0.01%.
Report is 23 commits behind head on main.
The diff coverage is 94.31%.

@@            Coverage Diff             @@
##             main   #12178      +/-   ##
==========================================
- Coverage   69.94%   69.93%   -0.01%     
==========================================
  Files        1411     1411              
  Lines      235298   235131     -167     
==========================================
- Hits       164581   164447     -134     
+ Misses      70717    70684      -33     

Flag	Coverage Δ
rust	69.93% <94.31%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
src/expr/src/error.rs	21.05% <ø> (ø)
src/expr/src/expr/build.rs	80.13% <ø> (+0.27%)	⬆️
src/expr/src/expr/mod.rs	60.00% <ø> (+5.45%)	⬆️
src/expr/src/vector_op/array.rs	62.50% <62.50%> (ø)
src/expr/src/vector_op/format.rs	86.90% <86.36%> (ø)
src/expr/macro/src/gen.rs	97.04% <98.48%> (+0.01%)	⬆️
src/common/src/array/data_chunk.rs	84.15% <100.00%> (+0.02%)	⬆️
src/expr/macro/src/lib.rs	91.48% <100.00%> (+0.09%)	⬆️
src/expr/macro/src/types.rs	93.54% <100.00%> (+0.07%)	⬆️
src/expr/src/sig/func.rs	87.50% <100.00%> (-0.93%)	⬇️
... and 3 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[xxchan]

I don't know if the change is good or bad, because the old impl can report error earlier 😇

[wangrunji0408]

Right. But it's not essential since we have to handle error at evaluation time anyways. It might be better to have an early check at binding time (e.g. if the format is constant, we ensure the number of arguments won't be too few.) Maybe we can add it back in the future. 😇

[xxchan]

Others LGTM