Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(proto): remove TypeName::Symbol and Char #2574

Merged
merged 1 commit into from
May 16, 2022

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented May 16, 2022

What's changed and what's your intention?

As title.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

closes #2568

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #2574 (a761b07) into main (ac6ba46) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2574      +/-   ##
==========================================
+ Coverage   71.93%   72.11%   +0.17%     
==========================================
  Files         676      678       +2     
  Lines       87564    88106     +542     
==========================================
+ Hits        62991    63538     +547     
+ Misses      24573    24568       -5     
Flag Coverage Δ
rust 72.11% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expr/src/expr/expr_literal.rs 90.99% <ø> (+0.25%) ⬆️
src/common/src/types/mod.rs 65.50% <100.00%> (-0.07%) ⬇️
src/expr/src/expr/build_expr_from_prost.rs 69.71% <100.00%> (ø)
src/expr/src/expr/expr_unary.rs 75.72% <100.00%> (ø)
src/storage/src/object/mod.rs 13.63% <0.00%> (-1.75%) ⬇️
src/expr/src/expr/mod.rs 47.61% <0.00%> (-1.17%) ⬇️
src/storage/src/store_impl.rs 5.79% <0.00%> (-0.99%) ⬇️
src/frontend/src/handler/create_index.rs 86.71% <0.00%> (-0.49%) ⬇️
src/frontend/src/catalog/catalog_service.rs 7.52% <0.00%> (-0.34%) ⬇️
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️
... and 34 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@fuyufjh fuyufjh merged commit 6fd6403 into main May 16, 2022
@fuyufjh fuyufjh deleted the eric/remove_symbol_and_type branch May 16, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proto: remove TypeName::Symbol and Char
2 participants