Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with reference parsing with Pandoc 2.11+ when multiple reference in same line #91

Closed
cderv opened this issue Jan 25, 2021 · 7 comments · Fixed by #92
Closed

Issue with reference parsing with Pandoc 2.11+ when multiple reference in same line #91

cderv opened this issue Jan 25, 2021 · 7 comments · Fixed by #92
Assignees
Labels
bug an unexpected problem or unintended behavior

Comments

@cderv
Copy link
Collaborator

cderv commented Jan 25, 2021

This is from https://community.rstudio.com/t/rstudio-ide-1-4-and-pandoc-completely-freezes/93792/8

In the skeleton file created using the package template, add this

See @R-rmarkdown for more information about **rmarkdown** and also @rmarkdown2018.

instead of

See @R-rmarkdown for more information about **rmarkdown**

in order to have 2 references in the same html line.

This will not be parsed correctly by margin_references and the first reference will be used twice.

I believe the issue is with regexec() + regmatches() - stringr::str_match_all() find everything.

@cderv cderv self-assigned this Jan 25, 2021
@cderv cderv added the bug an unexpected problem or unintended behavior label Jan 25, 2021
@cderv
Copy link
Collaborator Author

cderv commented Jan 25, 2021

This follows changes in 52aaff5

@cderv cderv closed this as completed in #92 Jan 25, 2021
cderv added a commit that referenced this issue Jan 26, 2021
complement to 6c09a71 for APA style.

Why: Using some specific styles will add attributes to the div of id #refs so  the regex to match those extra attributes
@cderv
Copy link
Collaborator Author

cderv commented Jan 26, 2021

There was an issue with APA style because the CSL processed by citeproc in Pandoc will add some more attributes to the div of id #refs. Fixed in 43ac801

Reported in the community: https://community.rstudio.com/t/rstudio-ide-1-4-and-pandoc-completely-freezes/93792/16

@mfansler
Copy link

When will this fix be pushed to CRAN? Is there something else holding up a 0.9.1 release?

@yihui
Copy link
Member

yihui commented May 17, 2021

@mfansler I can make the release in the next few days.

@yihui
Copy link
Member

yihui commented May 18, 2021

On CRAN now.

@mfansler
Copy link

@yihui thank you 🙏 ♥️

@github-actions
Copy link

github-actions bot commented Dec 4, 2021

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants