Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct refs in margins when several refs in same line #92

Merged
merged 14 commits into from
Jan 25, 2021
Merged

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Jan 25, 2021

This uses gsub to do multiple replacement as gregexec does not exists in base R.

This fixes #91 that causes wrong references to be used with Pandoc 2.11+

This also add tests and a GHA worflow for these. If we had tests I believe we would have seen this when chaging code to support Pandoc 2.11+

Test covers Pandoc 2.7.3 (RStudio 1.3), 2.11.3.2 (current RStudio 1.4 release), and Pandoc devel

@cderv cderv marked this pull request as draft January 25, 2021 18:55
@cderv cderv marked this pull request as ready for review January 25, 2021 21:28
@cderv cderv changed the title Correct reference in margins when several references in same line. Correct refs in margins when several refs in same line Jan 25, 2021
@cderv cderv merged commit 6c09a71 into master Jan 25, 2021
@cderv cderv deleted the fix-margin-ref branch January 25, 2021 21:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with reference parsing with Pandoc 2.11+ when multiple reference in same line
1 participant