-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minitest/GlobalExpectations
cop needs method chain support
#64
Labels
bug
Something isn't working
Comments
tejasbubane
added a commit
to tejasbubane/rubocop-minitest
that referenced
this issue
Mar 9, 2020
… chained methods Closes rubocop#64
8 tasks
tejasbubane
added a commit
to tejasbubane/rubocop-minitest
that referenced
this issue
Mar 10, 2020
… chained methods Closes rubocop#64
koic
added
bug
Something isn't working
and removed
enhancement
New feature or request
labels
Mar 10, 2020
koic
added a commit
that referenced
this issue
Mar 12, 2020
[Fix #64] Fix `Minitest/GlobalExpectations` autocorrection for chained methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks for releasing
rubocop-minitest 0.7.0
which implements #60.I'd like to apply this cop to google-cloud-storage gem and found it needs method chain support.
Expected behavior
Minitest/GlobalExpectations
cop corrects method chain correctly.Actual behavior
Minitest/GlobalExpectations
cop adds _() only the last method name then the test modified is getting error as follows.Steps to reproduce the problem
method_chain.rb
ruby method_chain.rb
to see if this file showsDEPRECATED: global use of must_equal from method_chain.rb:25. Use _(obj).must_equal instead. This will fail in Minitest 6.
and finishes successfullyrubocop --require rubocop-minitest --only Minitest/GlobalExpectations method_chain.rb -a
to auto-correctMinitest/GlobalExpectations
copruby method_chain.rb
RuboCop version
The text was updated successfully, but these errors were encountered: