[Fix rubocop#64] Fix Minitest/GlobalExpectations autocorrection for…

… chained methods Closes rubocop#64
tejasbubane · Mar 10, 2020 · b8f9e99 · b8f9e99
1 parent 0bc6c61
commit b8f9e99
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## master (unreleased)
 
+### Bug fixes
+
+* [#60](https:/rubocop-hq/rubocop-minitest/issues/60): Fix `Minitest/GlobalExpectations` autocorrection for chained methods. ([@tejasbubane][])
+
 ## 0.7.0 (2020-03-09)
 
 ### New features

diff --git a/lib/rubocop/cop/minitest/global_expectations.rb b/lib/rubocop/cop/minitest/global_expectations.rb
@@ -46,7 +46,7 @@ def autocorrect(node)
  return unless global_expectation?(node)
 
  lambda do |corrector|
- receiver = node.receiver.loc.selector
+ receiver = node.receiver.source_range
 
  if BLOCK_MATCHERS.include?(node.method_name)
  corrector.insert_before(receiver, '_ { ')

diff --git a/test/rubocop/cop/minitest/global_expectations_test.rb b/test/rubocop/cop/minitest/global_expectations_test.rb
@@ -35,6 +35,12 @@ def test_works_with_chained_method_calls
  ^^^^^^^^^^^^^^^^^^^^^^^ Prefer using `_(A.foo.bar).must_equal 42`.
  end
  RUBY
+
+ assert_correction(<<~RUBY)
+ it 'does something' do
+ _(A.foo.bar).must_equal 42
+ end
+ RUBY
  end
 
  RuboCop::Cop::Minitest::GlobalExpectations::BLOCK_MATCHERS.each do |matcher|