Fix zlib_installed not using the correct flags
#131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `zlib_installed` function does not use the correct compiler flags when checking if there already is a libz library pre-build. This causes libz-sys to build the internal libz version, which might be different from the pre-build libz version, and might cause issues with other libraries which also used the pre-build libz wether or not it's static or shared. I came across this when using my custom toolchain build images to build static musl binaries. And this crate seemed to build the built-in version anyways. Which is an other issue, not addressed in this PR.
BlackDex
changed the title
zlib_installed not using the correct flags
Byron
approved these changes
May 30, 2023
There was a problem hiding this comment.
Thanks a lot for the fix! Even though I have no experience with the build system used, but judging from the documentation of to_command() it should be the correct way to go from compiler tool to invocable command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
zlib_installedfunction does not use the correct compiler flags when checking if there already is a libz library pre-build.This causes libz-sys to build the internal libz version, which might be different from the pre-build libz version, and might cause issues with other libraries which also used the pre-build libz wether or not it's static or shared.
I came across this when using my custom toolchain build images to build static musl binaries. And this crate seemed to build the built-in version anyways. Which is an other issue, not addressed in this PR.