Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zlib_installed not using the correct flags #131

Merged
merged 2 commits into from
May 30, 2023

Commits on May 29, 2023

  1. Fix zlib_installed not using the correct flags

    The `zlib_installed` function does not use the correct compiler flags
    when checking if there already is a libz library pre-build.
    
    This causes libz-sys to build the internal libz version, which might be
    different from the pre-build libz version, and might cause issues with
    other libraries which also used the pre-build libz wether or not it's
    static or shared.
    
    I came across this when using my custom toolchain build images to build
    static musl binaries. And this crate seemed to build the built-in
    version anyways. Which is an other issue, not addressed in this PR.
    BlackDex committed May 29, 2023
    Configuration menu
    Copy the full SHA
    56ebad4 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. refactor

    Save two lines without being less descriptive.
    Byron committed May 30, 2023
    Configuration menu
    Copy the full SHA
    cdcca21 View commit details
    Browse the repository at this point in the history