Retrieve LLVM version from llvm-filecheck binary if it is not set yet #103203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
fix-llvm-runtools-condition
branch
from
5507355
to
9c49742
Compare
GuillaumeGomez
changed the title
--allow-unused-prefixes all the time
Amanieu
reviewed
Oct 18, 2022
GuillaumeGomez
force-pushed
the
fix-llvm-runtools-condition
branch
from
9c49742
to
d5fd1af
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
Can't we just pass the argument unconditionally? LLVM 13 is out minimum version anyway. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 18, 2022
…ondition, r=Amanieu Retrieve LLVM version from llvm-filecheck binary if it is not set yet In `rustc_codegen_gcc`, we run the `ASM` test suite. The problem is that, if a too recent version of the `llvm-filecheck` binary is provided, an extra argument needs to be passed and the to detect this version, it currently only expects a `--llvm-version` argument. With this, the version can be determined directly from the `llvm-filecheck` binary. r? `@Amanieu`
This was referenced Oct 18, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 19, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#101889 (doc: rewrite doc for uint::{carrying_add,borrowing_sub}) - rust-lang#102507 (More slice::partition_point examples) - rust-lang#103164 (rustdoc: remove CSS ``@media` (min-width: 701px)`) - rust-lang#103189 (Clean up code-color and headers-color rustdoc GUI tests) - rust-lang#103203 (Retrieve LLVM version from llvm-filecheck binary if it is not set yet) - rust-lang#103204 (Add some more autolabels) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
rustc_codegen_gcc, we run theASMtest suite. The problem is that, if a too recent version of thellvm-filecheckbinary is provided, an extra argument needs to be passed and the to detect this version, it currently only expects a--llvm-versionargument. With this, the version can be determined directly from thellvm-filecheckbinary.r? @Amanieu