Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more autolabels #103204

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Add some more autolabels #103204

merged 1 commit into from
Oct 19, 2022

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Oct 18, 2022

No description provided.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2022
@jyn514
Copy link
Member Author

jyn514 commented Oct 18, 2022

@bors rollup

@jyn514 jyn514 added the A-meta Area: Issues & PRs about the rust-lang/rust repository itself label Oct 18, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 18, 2022

📌 Commit 10f982d has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 18, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 19, 2022
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#101889 (doc: rewrite doc for uint::{carrying_add,borrowing_sub})
 - rust-lang#102507 (More slice::partition_point examples)
 - rust-lang#103164 (rustdoc: remove CSS ``@media` (min-width: 701px)`)
 - rust-lang#103189 (Clean up code-color and headers-color rustdoc GUI tests)
 - rust-lang#103203 (Retrieve LLVM version from llvm-filecheck binary if it is not set yet)
 - rust-lang#103204 (Add some more autolabels)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e0c162f into rust-lang:master Oct 19, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 19, 2022
@@ -203,6 +208,38 @@ trigger_files = [
"compiler/rustc_macros/src/query.rs"
]

[autolabel."A-testsuite"]
trigger_files = [
"src/test",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this from the autolabel? This causes basically every compiler PR to be labeled A-testsuite, since almost every compiler PR has an associated UI test with it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, makes sense. Not sure when I'll have time though.

@jyn514 jyn514 deleted the autolabels branch October 20, 2022 16:43
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 20, 2022
Don't label `src/test` tests as `A-testsuite`

Nearly every PR modifies `src/test`; A-testsuite is meant to be for things affecting the test runners themselves.

cc rust-lang#103204 (comment)

r? `@jyn514`
@@ -181,6 +181,11 @@ trigger_files = [
"x.py",
"src/bootstrap",
"src/tools/rust-installer",
"configure",
"Cargo.toml",
"Cargo.lock",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one supposed to be here? Adding any dependency to any rustc crate now makes the bot add the A-bootstrap label.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 17, 2023
Don't add A-bootstrap to PRs modifying Cargo.lock

Changing Cargo.lock is common even when adding dependencies between existing rustc crates.

cc rust-lang#103204 (comment), `@m-ou-se`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants