Rollup of 9 pull requests #103322
Merged
Rollup of 9 pull requests #103322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make the structure of the two variants more similar. - Add some comments. - Move various conditional `use` items inside the function that uses them. - Inline some closures.
It took me a while to work this out.
…s input vs output
Fix `SelfVisitor::is_self_ty` ICE Fixes rust-lang#103202
Clarify startup A small follow-up to rust-lang#102769. r? `@jyn514`
Adjust `transmute{,_copy}` to be clearer about which of `T` and `U` is input vs output
This is essentially a documentation-only change (although it does touch code in an irrelevant way).
Fixed docs typo in `library/std/src/time.rs` * Changed comment from `Previous rust versions panicked when self was earlier than the current time.` to `Previous rust versions panicked when the current time was earlier than self.` * Resolves rust-lang#103282.
…rtcuts, r=notriddle +/- shortcut now only expand/collapse, not both Fixes rust-lang#102772. r? ```@notriddle```
Don't label `src/test` tests as `A-testsuite` Nearly every PR modifies `src/test`; A-testsuite is meant to be for things affecting the test runners themselves. cc rust-lang#103204 (comment) r? `@jyn514`
…r=bjorn3 interpret: remove an incorrect assertion This fixes an ICE in Miri, [reported](https://rust-lang.zulipchat.com/#narrow/stream/269128-miri/topic/SwitchInt.20with.20no.20targets.3F) by `@saethlin.` The faulty assertion was introduced by rust-lang@432535d, when a previously correct assertion checking that the `otherwise` target exists got replaced by this assertion checking that at least one more target beyond `otherwise` exists. Sadly we don't have a small reproducer so I don't think we can easily add a testcase.
…nst_msg, r=oli-obk Improve "`~const` is not allowed here" message r? `@oli-obk`
rustbot
added
A-meta
|
@bors r+ rollup=never p=9 |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 5ffa67d730 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (dcb3761): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
SelfVisitor::is_self_tyICE #103221 (FixSelfVisitor::is_self_tyICE)transmute{,_copy}to be clearer about which ofTandUis input vs output #103281 (Adjusttransmute{,_copy}to be clearer about which ofTandUis input vs output)library/std/src/time.rs#103288 (Fixed docs typo inlibrary/std/src/time.rs)src/testtests asA-testsuite#103313 (Don't labelsrc/testtests asA-testsuite)~constis not allowed here" message #103319 (Improve "~constis not allowed here" message)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup