Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #120431

Closed
wants to merge 33 commits into from

Commits on Oct 12, 2023

  1. Configuration menu
    Copy the full SHA
    a208662 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Update primitive_docs.rs

    joshlf authored Oct 13, 2023
    Configuration menu
    Copy the full SHA
    4f0192a View commit details
    Browse the repository at this point in the history
  2. Update library/core/src/primitive_docs.rs

    Co-authored-by: Ralf Jung <[email protected]>
    joshlf and RalfJung authored Oct 13, 2023
    Configuration menu
    Copy the full SHA
    39660c4 View commit details
    Browse the repository at this point in the history
  3. Update primitive_docs.rs

    joshlf authored Oct 13, 2023
    Configuration menu
    Copy the full SHA
    55487e2 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Update primitive_docs.rs

    joshlf authored Nov 3, 2023
    Configuration menu
    Copy the full SHA
    1a0309a View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. tidy: wrap regexes with lazy_static

    yes, once_cell better, but ...
    
    this reduces from
    
    ==31349== Total:     1,365,199,543 bytes in 4,774,213 blocks
    ==31349== At t-gmax: 10,975,708 bytes in 66,093 blocks
    ==31349== At t-end:  2,880,947 bytes in 12,332 blocks
    ==31349== Reads:     5,210,008,956 bytes
    ==31349== Writes:    1,280,920,127 bytes
    
    to
    
    ==47796== Total:     821,467,407 bytes in 3,955,595 blocks
    ==47796== At t-gmax: 10,976,209 bytes in 66,100 blocks
    ==47796== At t-end:  2,944,016 bytes in 12,490 blocks
    ==47796== Reads:     4,788,959,023 bytes
    ==47796== Writes:    975,493,639 bytes
    
    miropt-test-tools: remove regex usage
    
    this removes regex usage and slightly refactors ext stripping in one case
    klensy committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    2bb3210 View commit details
    Browse the repository at this point in the history
  2. update ignore crate

     $ cargo update  -p ignore --precise=0.4.22
        Updating crates.io index
        Updating aho-corasick v1.0.2 -> v1.1.2
        Updating bstr v1.5.0 -> v1.9.0
        Updating globset v0.4.10 -> v0.4.14
        Updating ignore v0.4.20 -> v0.4.22
        Updating log v0.4.19 -> v0.4.20
        Updating memchr v2.5.0 -> v2.7.1
          Adding regex-automata v0.4.3
        Updating walkdir v2.3.3 -> v2.4.0
    
    some notable change is BurntSushi/ripgrep#2692
    
    reduces memory usage from
    
    ==47796== Total:     821,467,407 bytes in 3,955,595 blocks
    ==47796== At t-gmax: 10,976,209 bytes in 66,100 blocks
    ==47796== At t-end:  2,944,016 bytes in 12,490 blocks
    ==47796== Reads:     4,788,959,023 bytes
    ==47796== Writes:    975,493,639 bytes
    
    to
    
    ==66633== Total:     791,565,538 bytes in 3,503,144 blocks
    ==66633== At t-gmax: 10,914,511 bytes in 65,997 blocks
    ==66633== At t-end:  395,531 bytes in 941 blocks
    ==66633== Reads:     4,249,388,949 bytes
    ==66633== Writes:    814,119,580 bytes
    
    bump regex to dedupe one regex-syntax
    
    $ cargo update -p regex
        Updating crates.io index
        Updating regex v1.8.4 -> v1.10.2
        Removing regex-syntax v0.7.2
    klensy committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    3249174 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Improve documentation for [A]Rc::into_inner

    General improvements, and also aims to better encourage the reader
    to actually check out Arc::try_unwrap.
    steffahn committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    ab938b9 View commit details
    Browse the repository at this point in the history
  2. Add support for custom JSON targets when using build-std.

    Currently, when building with `build-std`, some library build scripts
    check properties of the target by inspecting the target triple at
    `env::TARGET`, which is simply set to the filename of the JSON file
    when using JSON target files.
    
    This patch alters these build scripts to use `env::CARGO_CFG_*` to
    fetch target information instead, allowing JSON target files
    describing platforms without `restricted_std` to build correctly when
    using `-Z build-std`.
    
    Fixes wg-cargo-std-aware/rust-lang#60.
    c272 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    797cf59 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Update primitive_docs.rs

    joshlf authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    c2c6e33 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. fix issue 120040

    HTGAzureX1212 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    3269513 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8f89e57 View commit details
    Browse the repository at this point in the history
  3. fix

    HTGAzureX1212 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    2241d16 View commit details
    Browse the repository at this point in the history
  4. Update codegen test for LLVM 18

    nikic committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    bdf7404 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    40f5e68 View commit details
    Browse the repository at this point in the history
  6. Skip building cranelift for Fuchsia

    This refactors run.sh to never override an explicit $CODEGEN_BACKENDS if
    set in the build.
    tmandry committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    53bf511 View commit details
    Browse the repository at this point in the history
  7. Bump Fuchsia (includes building tests)

    This includes a change to the upstream build_fuchsia_from_rust_ci script
    that builds a minimal set of tests, to improve coverage on this builder.
    tmandry committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    afd5edc View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. Configuration menu
    Copy the full SHA
    e26f213 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    018bf30 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f5c7895 View commit details
    Browse the repository at this point in the history
  4. Remove unnecessary unit returns in query declarations

    For consistency with normal functions.
    DaniPopes committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    cda898b View commit details
    Browse the repository at this point in the history
  5. Update primitive_docs.rs

    joshlf authored Jan 27, 2024
    Configuration menu
    Copy the full SHA
    b867c7c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5d8c178 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#116677 - joshlf:patch-11, r=RalfJung

    References refer to allocated objects
    
    Partially addresses rust-lang/unsafe-code-guidelines#465
    matthiaskrgr authored Jan 27, 2024
    Configuration menu
    Copy the full SHA
    bead151 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#120023 - klensy:tidy-alloc, r=Mark-Simulacrum

    tidy: reduce allocs
    
    this reduces allocs in tidy from (dhat output)
    
    ```
    ==31349== Total:     1,365,199,543 bytes in 4,774,213 blocks
    ==31349== At t-gmax: 10,975,708 bytes in 66,093 blocks
    ==31349== At t-end:  2,880,947 bytes in 12,332 blocks
    ==31349== Reads:     5,210,008,956 bytes
    ==31349== Writes:    1,280,920,127 bytes
    ```
    to
    ```
    ==66633== Total:     791,565,538 bytes in 3,503,144 blocks
    ==66633== At t-gmax: 10,914,511 bytes in 65,997 blocks
    ==66633== At t-end:  395,531 bytes in 941 blocks
    ==66633== Reads:     4,249,388,949 bytes
    ==66633== Writes:    814,119,580 bytes
    ```
    
    by wrapping regex and updating `ignore` (effect probably not only from `ignore`, didn't measured)
    matthiaskrgr authored Jan 27, 2024
    Configuration menu
    Copy the full SHA
    9f07a7b View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#120232 - c272:json-buildstd, r=Mark-Simulacrum

    Add support for custom JSON targets when using build-std.
    
    Currently, when building with `build-std`, some library build scripts check properties of the target by inspecting the target triple at `env::TARGET`, which is simply set to the filename of the JSON file when using JSON target files.
    
    This patch alters these build scripts to use `env::CARGO_CFG_*` to fetch target information instead, allowing JSON target files describing platforms without `restricted_std` to build correctly when using `-Z build-std`. There are some weak assertions here (for example, `nintendo && newlib`), however this seems at least a marginal improvement on the existing solution.
    
    Fixes rust-lang/wg-cargo-std-aware#60.
    matthiaskrgr authored Jan 27, 2024
    Configuration menu
    Copy the full SHA
    52be0be View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#120266 - steffahn:a_rc_into_inner_docs, r=M…

    …ark-Simulacrum
    
    Improve documentation for [A]Rc::into_inner
    
    General improvements, and also aims to better encourage the reader to actually check out Arc::try_unwrap.
    
    This addresses concerns from rust-lang#106894 (comment).
    
    Rendered:
    
    ![Screenshot_20240123_114436](https:/rust-lang/rust/assets/3986214/68896d62-13e0-4f3a-8073-91d8e77c5554)
    ![Screenshot_20240123_114455](https:/rust-lang/rust/assets/3986214/dc58e4bd-dd7f-40b1-bc50-fd6200dde593)
    matthiaskrgr authored Jan 27, 2024
    Configuration menu
    Copy the full SHA
    ac8c8fe View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#120358 - tmandry:bump-fuchsia-8c-tests, r=M…

    …ark-Simulacrum
    
    Bump Fuchsia, build tests, and use 8 core bots
    
    - Build Fuchsia on 8 cores instead of 16
    - Skip building cranelift for Fuchsia
    - Bump Fuchsia (includes building tests)
    
    This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder. This would have caught rust-lang/rust-clippy#11952 and rust-lang#119593.
    
    See prior discussion on rust-lang#119400 about building on 8 cores instead of 16. This PR combines changes from that and rust-lang#119399, plus clean up.
    
    r? ``@Mark-Simulacrum``
    matthiaskrgr authored Jan 27, 2024
    Configuration menu
    Copy the full SHA
    68b39be View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#120373 - HTGAzureX1212:HTGAzureX1212/issue-…

    …120040, r=ChrisDenton
    
    Adjust Behaviour of `read_dir` and `ReadDir` in Windows Implementation: Check Whether Path to Search In Exists
    
    This pull request changes the `read_dir` function's and the `ReadDir` structure's internal implementations for the Windows operating system to make its behaviour more accurate.
    
    It should be noted that `ERROR_FILE_NOT_FOUND` is returned by the `FindFirstFileW` function when *no matching files can be found*, not necessarily that the path to search in does not exist in the first place. Therefore, directly returning the "The system cannot find the file specified." may not be accurate.
    
    An extra check for whether the path to search in exists is added, returning a constructed `ReadDir` iterator with its handle being an `INVALID_HANDLE_VALUE` returned by the `FindFirstFileW` function if `ERROR_FILE_NOT_FOUND` is indeed the last OS error. The `ReadDir` implementation for the Windows operating system is correspondingly updated to always return `None` if the handle it has is an `INVALID_HANDLE_VALUE` which can only be the case if and only if specifically constructed by the `read_dir` function in the aforementioned conditions.
    
    It should also be noted that `FindFirstFileW` would have returned `ERROR_PATH_NOT_FOUND` if the path to search in does not exist in the first place.
    
    Presumably fixes rust-lang#120040.
    matthiaskrgr authored Jan 27, 2024
    Configuration menu
    Copy the full SHA
    34f0710 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#120376 - nikic:update-codegen-test, r=cuviper

    Update codegen test for LLVM 18
    
    r? `````@cuviper`````
    matthiaskrgr authored Jan 27, 2024
    Configuration menu
    Copy the full SHA
    81ae2d4 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#120402 - compiler-errors:async-closure-def-…

    …tree, r=cjgillot
    
    Make the coroutine def id of an async closure the child of the closure def id
    
    Adjust def collection to make the (inner) coroutine returned by an async closure be a def id child of the (outer) closure. This makes it easy to map from coroutine -> closure by using `tcx.parent`, since currently it's not trivial to do this.
    matthiaskrgr authored Jan 27, 2024
    Configuration menu
    Copy the full SHA
    87f116b View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#120420 - lnicola:rm-pattern-analysis-deriva…

    …tive, r=Nilstrieb
    
    Stop using derivative in rustc_pattern_analysis
    
    CC rust-lang#109302, rust-lang/rust-analyzer#16420 (comment)
    
    r? `@Nadrieril`
    matthiaskrgr authored Jan 27, 2024
    Configuration menu
    Copy the full SHA
    561d6f0 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#120425 - DaniPopes:query-default-return, r=…

    …Nilstrieb
    
    Remove unnecessary unit returns in query declarations
    
    For consistency with normal functions.
    matthiaskrgr authored Jan 27, 2024
    Configuration menu
    Copy the full SHA
    7274c3a View commit details
    Browse the repository at this point in the history