Pass a TyCtxt through to FormatRender
#80090
Conversation
jyn514
added
the
T-rustdoc
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
jyn514
force-pushed
the
tcx-in-render
branch
from
5b78318
to
b0838d8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #80114) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
|
Since both this and #80119 add |
|
Err maybe not? I'm starting to lose track of which changes happened in which PRs 😆 too many open at the same time. |
First actually useful step in rust-lang#76382 This doesn't yet compile because there's no way to get a `Lrc<Session>` from a TyCtxt, only a `&Session`.
Apparently expansion() really does return Rc, not Lrc
jyn514
force-pushed
the
tcx-in-render
branch
from
4654790
to
0c2f76a
Compare
|
Quite a lot of information was stored in the first pass to not have the r=me if this is ready for you (you seemed to be doing some tests still? 😄 ) |
|
This is ready to go, I was just fixing a rebase conflict. @bors r=GuillaumeGomez |
|
📌 Commit 0c2f76a has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Tested on commit rust-lang/rust@d8d3ab9. Direct link to PR: <rust-lang/rust#80090> 🎉 rls on linux: test-fail → test-pass (cc @Xanewok).
…meGomez [rustdoc] Calculate stability, const_stability, and deprecation on-demand Previously, they would always be calculated ahead of time, which bloated the size of `clean::Item`. Builds on rust-lang#80090 and should not be merged before. Helps with rust-lang#79103 and rust-lang#76382. cc rust-lang#80014 (comment) This brings `Item` down to 568 bytes, down from 616.
…umeGomez Remove `DefPath` from `Visibility` and calculate it on demand Depends on rust-lang#80090 and should not be merged before. Helps with rust-lang#79103 and rust-lang#76382. cc rust-lang#80014 (comment) - `@nnethercote` I figured it out! It was simpler than I expected :) This brings the size of `clean::Visibility` down from 40 bytes to 8. Note that this does *not* remove `clean::Visibility`, even though it's now basically the same as `ty::Visibility`, because the `Invsible` variant means something different from `Inherited` and I thought it would be be confusing to merge the two. See the new comments on `impl Clean for ty::Visibility` for details.
This is the next step after #79957 for #76382. Eventually I plan to use this to remove
stability,const_stability, anddeprecationfromItem, but that needs more extensive changes (in particular, #75355 or something like it).This has no actual changes to behavior, it's just moving types around.
ccc #80014 (comment)