Continue String to Symbol conversion in rustdoc (1) #80119
Conversation
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
str-to-symbol
branch
from
7da0128
to
c3ad0aa
Compare
| @@ -163,7 +163,9 @@ impl From<clean::ItemKind> for ItemEnum { | |||
| use clean::ItemKind::*; | |||
| match item { | |||
| ModuleItem(m) => ItemEnum::ModuleItem(m.into()), | |||
There was a problem hiding this comment.
ItemEnum should probably be renamed at some point, but no need to do it here.
There was a problem hiding this comment.
Maybe open an issue so we don't forget? (And mark it as e-easy too ;) )
jyn514
added
C-cleanup
GuillaumeGomez
force-pushed
the
str-to-symbol
branch
from
c3ad0aa
to
44e226c
Compare
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. |
|
⌛ Trying commit 44e226c with merge ac57a14252d79c3da055dc82c0c5e253444fbc26... |
|
☀️ Try build successful - checks-actions |
|
Queued ac57a14252d79c3da055dc82c0c5e253444fbc26 with parent caeb333, future comparison URL. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
Finished benchmarking try commit (ac57a14252d79c3da055dc82c0c5e253444fbc26): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
rustbot
removed
the
S-waiting-on-perf
|
-2.2% on instruction count, -1.5% on max-rss 🎉 🎉 @bors r+ rollup=never |
|
📌 Commit 44e226c has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Tested on commit rust-lang/rust@fee693d. Direct link to PR: <rust-lang/rust#80119> 💔 rls on linux: test-pass → test-fail (cc @Xanewok).
jyn514
changed the title
Continue String to Symbol conversion in rustdoc (2) Follow-up of rust-lang#80119. This is the last one (and I actually expected more conversions but seems like it was the last one remaining...). r? `@jyn514`
rustdoc DocFragment rework Kind of a follow-up of rust-lang#80119. A few things are happening in this PR. I'm not sure about the impact on perf though so I'm very interested about that too (if the perf is worse, then we can just close this PR). The idea here is mostly about reducing the memory usage by relying even more on `Symbol` instead of `String`. The only issue is that `DocFragment` has 3 modifications performed on it: 1. Unindenting 2. Collapsing similar comments into one 3. "Beautifying" (weird JS-like comments handling). To do so, I saved the information about unindent and the "collapse" is now on-demand (which is why I'm not sure the perf will be better, it has to be run multiple times...). r? `@jyn514`
Follow-up of #80091.
This PR is already big enough so I'll stop here before the next one.
r? @jyn514